Fix scale transform on Android #9251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @kmagiera to be a potential reviewer. |
ghost
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit Thanks for jumping on this so quickly! |
ghost
added
the
CLA Signed
|
@astreet Looks like shipit bot didn't pick that up. |
ghost
added
the
CLA Signed
|
@facebook-github-bot shipit |
|
If that doesn't work I'll post internally |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing.If you are an FB employee go to Phabricator to review internal test results. |
|
I think the bot doesn't pickup 'shipit' + some text after. It does work with some text + 'shipit' after. |
ghost
added
the
CLA Signed
cmcewen
pushed a commit
to cmcewen/react-native
that referenced
this pull request
Aug 15, 2016
Summary: cc kmagiera astreet Closes facebook#9251 Differential Revision: D3679466 Pulled By: astreet fbshipit-source-id: bd4262169827151ed584f7f8d167f9e6b8d533af
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: cc kmagiera astreet Closes facebook#9251 Differential Revision: D3679466 Pulled By: astreet fbshipit-source-id: bd4262169827151ed584f7f8d167f9e6b8d533af
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8892 broke scale transforms on Android as the new implementation did a Z scale for the
scaletransform instead of a XY scale.cc @kmagiera @astreet