Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context should propagate across React.renderComponent() #1260

Closed
petehunt opened this issue Mar 14, 2014 · 8 comments
Closed

context should propagate across React.renderComponent() #1260

petehunt opened this issue Mar 14, 2014 · 8 comments

Comments

@petehunt
Copy link
Contributor

I really want this to work: http://jsfiddle.net/RxRK8/

@lrowe
Copy link
Contributor

lrowe commented Mar 20, 2014

This would be great. I currently use this.transferPropsTo(...) through most of my app to avoid explicitly passing down my core application objects.

@syranide
Copy link
Contributor

👍

@jsdir
Copy link

jsdir commented May 25, 2014

From what I've observed, context seems to only propagate to children that are explicitly created in render(). I would also like to know if this is going to change in the future.

@ghempton
Copy link

👍 this functionality seems really useful

@ghempton
Copy link

At the very least it would be nice if cloneWithProps inherited the context, but that doesn't seem to be the case either

@ericclemmons
Copy link
Contributor

I'm with @petehunt. Knowing that React.withContext will be deprecated, there are few options to handle this.

@RickWong
Copy link

👍 Maybe the deprecation of React.withContext was premature.

@jimfb
Copy link
Contributor

jimfb commented Mar 10, 2015

Context is going to be parent-based, so this request is obsolete. Closing.

@jimfb jimfb closed this as completed Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants