-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add https support to standalone DevTools #19111
Comments
It might be because a http server is used? There is the possibility to use the https server variant, but you need some certificate setup and such. |
Yea, I think certificate is not a problem because we can do something like https://webpack.js.org/configuration/dev-server/#devserverhttps |
Feel free. Haven't thought about this enough to have an opinion yet. |
Sorry Brian, these days are too busy, I did some work on NE-SmallTown@cebb026 but have not enough time to do more verification, add docs and add tests, so I have to left it there. Sorry agign. |
I notice that the standalone react-devtools use http instead https like
"<script src="http://192.1.2.3:8097"></script>"
(src code),but my website is always https, so it will get broken because I cant change it to http if it's iniframe
(it's diffcult to change the host environment/website protocol).I'm not familar with the react-devtools implementations, maybe something cause it can only use http to open the server, happy to hear the details, thanks!
React-devtools: 3.6.3
The text was updated successfully, but these errors were encountered: