Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug(react-devtools-inline@4.11.0): publish artifact points to /Users/bvaughn/Documents/git/react.devtools/ #21235

Closed
AviVahl opened this issue Apr 11, 2021 · 5 comments · Fixed by #21237
Closed

Bug(react-devtools-inline@4.11.0): publish artifact points to /Users/bvaughn/Documents/git/react.devtools/ #21235

AviVahl opened this issue Apr 11, 2021 · 5 comments · Fixed by #21237
Assignees
@bvaughn
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@AviVahl
Copy link

AviVahl commented Apr 11, 2021

Published react-devtools-inline@4.11.0 has the following piece of code in react-devtools-inline/dist/backend.js:

module.exports = require("/Users/bvaughn/Documents/git/react.devtools/packages/react-devtools-shared/src/config/DevToolsFeatureFlags.default");

🙄
@AviVahl AviVahl added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Apr 11, 2021
@AviVahl
Copy link
Author

AviVahl commented Apr 11, 2021

FYI @bvaughn

@bvaughn
Copy link
Contributor

bvaughn commented Apr 11, 2021

Huh. That's no good.

@bvaughn bvaughn self-assigned this Apr 11, 2021
@bvaughn
Copy link
Contributor

bvaughn commented Apr 11, 2021

This is because I accidentally put the module map in an externals map rather than a resolve.alias map. Oops.

@bvaughn bvaughn mentioned this issue Apr 11, 2021
Merged
@bvaughn
Copy link
Contributor

bvaughn commented Apr 11, 2021

Fix published in 4.11.1

@bvaughn bvaughn closed this as completed Apr 11, 2021
@AviVahl
Copy link
Author

AviVahl commented Apr 11, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed broken feature flag import for DT inline package bvaughn/react
3 participants
@bvaughn @AviVahl @eps1lon