Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Float][Fizz] add crossOrigin support for preloading bootstrap scripts and bootstrap modules #26942

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Jun 13, 2023

The recently merged support for crossorigin in bootstrap scripts did not implement the functionality for preloading. This adds it

see #26844

…not implement the functionality for preloading. This adds it
@gnoff gnoff requested a review from sophiebits June 13, 2023 20:54
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Jun 13, 2023
@gnoff gnoff changed the title The recently merged support for crossorigin in bootstrap scripts did … [Float][Fizz] The recently merged support for crossorigin in bootstrap scripts did … Jun 13, 2023
@gnoff gnoff changed the title [Float][Fizz] The recently merged support for crossorigin in bootstrap scripts did … [Float][Fizz] add crossOrigin support for preloading bootstrap scripts and bootstrap modules Jun 13, 2023
@react-sizebot
Copy link

Comparing: 7ed6084...d7ef27d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.23 kB 164.23 kB = 51.73 kB 51.73 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.67 kB 171.67 kB = 53.97 kB 53.97 kB
facebook-www/ReactDOM-prod.classic.js = 570.12 kB 570.12 kB = 100.58 kB 100.58 kB
facebook-www/ReactDOM-prod.modern.js = 553.90 kB 553.90 kB = 97.75 kB 97.75 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against d7ef27d

@gnoff gnoff merged commit a7bf5ba into facebook:main Jun 13, 2023
35 of 36 checks passed
@gnoff gnoff deleted the crossorigin-bootstrap-preload branch June 13, 2023 20:59
@gnoff
Copy link
Collaborator Author

gnoff commented Jun 13, 2023

Merging without stamp to fix broken tests on main

github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
…s and bootstrap modules (#26942)

The recently merged support for crossorigin in bootstrap scripts did not
implement the functionality for preloading. This adds it

see #26844

DiffTrain build for [a7bf5ba](a7bf5ba)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…s and bootstrap modules (facebook#26942)

The recently merged support for crossorigin in bootstrap scripts did not
implement the functionality for preloading. This adds it

see facebook#26844
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…s and bootstrap modules (#26942)

The recently merged support for crossorigin in bootstrap scripts did not
implement the functionality for preloading. This adds it

see #26844

DiffTrain build for commit a7bf5ba.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants