Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOM] Add unstable_batchedUpdates to server-rendering-stub #27028

Merged
merged 1 commit into from
Jun 30, 2023
Merged

[DOM] Add unstable_batchedUpdates to server-rendering-stub #27028

merged 1 commit into from
Jun 30, 2023

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Jun 30, 2023

unstable_batchedUpdates shouldn't really be called on the server but the semantics are clear enough and we can provide a trivial implementation that calls the provided callback so we are adding it to the server-rendering-stub.

This means we will also keep it around when we make the top level react-dom exports match the server-rendering-stub in the next major

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 30, 2023
@gnoff gnoff mentioned this pull request Jun 30, 2023
Closed
@gnoff gnoff requested a review from sebmarkbage June 30, 2023 18:00
@react-sizebot
Copy link

Comparing: 7f362de...51cab22

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.22 kB 164.22 kB = 51.74 kB 51.74 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.63 kB 171.63 kB = 53.95 kB 53.95 kB
facebook-www/ReactDOM-prod.classic.js = 566.78 kB 566.78 kB = 99.97 kB 99.97 kB
facebook-www/ReactDOM-prod.modern.js = 550.58 kB 550.58 kB = 97.13 kB 97.13 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +9.06% 3.70 kB 4.03 kB +11.74% 1.23 kB 1.37 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +9.00% 3.72 kB 4.06 kB +11.72% 1.25 kB 1.40 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +8.47% 4.12 kB 4.47 kB +10.87% 1.34 kB 1.49 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +8.42% 4.15 kB 4.50 kB +10.80% 1.37 kB 1.52 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +5.38% 6.22 kB 6.56 kB +6.41% 2.29 kB 2.44 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +5.17% 6.76 kB 7.10 kB +6.08% 2.42 kB 2.57 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +4.94% 1.22 kB 1.28 kB +3.66% 0.68 kB 0.71 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +4.83% 1.24 kB 1.30 kB +3.54% 0.71 kB 0.73 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +4.32% 1.37 kB 1.43 kB +3.17% 0.76 kB 0.78 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +3.71% 1.43 kB 1.48 kB +2.73% 0.81 kB 0.83 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +3.64% 1.46 kB 1.51 kB +2.77% 0.83 kB 0.85 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +3.32% 1.60 kB 1.65 kB +2.51% 0.88 kB 0.90 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +9.06% 3.70 kB 4.03 kB +11.74% 1.23 kB 1.37 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +9.00% 3.72 kB 4.06 kB +11.72% 1.25 kB 1.40 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +8.47% 4.12 kB 4.47 kB +10.87% 1.34 kB 1.49 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +8.42% 4.15 kB 4.50 kB +10.80% 1.37 kB 1.52 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +5.38% 6.22 kB 6.56 kB +6.41% 2.29 kB 2.44 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +5.17% 6.76 kB 7.10 kB +6.08% 2.42 kB 2.57 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +4.94% 1.22 kB 1.28 kB +3.66% 0.68 kB 0.71 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +4.83% 1.24 kB 1.30 kB +3.54% 0.71 kB 0.73 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +4.32% 1.37 kB 1.43 kB +3.17% 0.76 kB 0.78 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +3.71% 1.43 kB 1.48 kB +2.73% 0.81 kB 0.83 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +3.64% 1.46 kB 1.51 kB +2.77% 0.83 kB 0.85 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +3.32% 1.60 kB 1.65 kB +2.51% 0.88 kB 0.90 kB

Generated by 🚫 dangerJS against 51cab22

@gnoff gnoff merged commit 1fdacbe into facebook:main Jun 30, 2023
36 checks passed
@gnoff gnoff deleted the server-stub-exports branch June 30, 2023 18:19
@styfle styfle mentioned this pull request Jun 30, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Jul 4, 2023
@styfle @shuding
chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630 (#52005)
9e4b87d 
This PR updates the vendored react dependencies using `pnpm sync-react`

### React upstream changes

- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

### Related

Closes #49409 (by facebook/react#26977)
fix NEXT-1189

Co-authored-by: Shu Ding <g@shud.in>
@styfle styfle mentioned this pull request Jul 5, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Jul 6, 2023
@styfle @huozhi
chore(deps): bump react to 7118f5dd7 (#52282)
6dafc42 
Fixes #49409

### React upstream changes

- facebook/react#27045
- facebook/react#27051
- facebook/react#27032
- facebook/react#27031
- facebook/react#27029
- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

---------

Co-authored-by: Jiachi Liu <inbox@huozhi.im>
shuding added a commit to vercel/next.js that referenced this pull request Jul 8, 2023
@styfle @shuding
chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630 (#52005)
1ae3f42 
This PR updates the vendored react dependencies using `pnpm sync-react`

### React upstream changes

- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

### Related

Closes #49409 (by facebook/react#26977)
fix NEXT-1189

Co-authored-by: Shu Ding <g@shud.in>
@idiom-bytes idiom-bytes mentioned this pull request Jul 13, 2023
Merged
This was referenced Jul 20, 2023
Closed
Closed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@gnoff @AndyPengc12
[DOM] Add unstable_batchedUpdates to server-rendering-stub (facebook#…
63cd14e 
…27028)

`unstable_batchedUpdates` shouldn't really be called on the server but
the semantics are clear enough and we can provide a trivial
implementation that calls the provided callback so we are adding it to
the server-rendering-stub.

This means we will also keep it around when we make the top level
react-dom exports match the server-rendering-stub in the next major
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@gnoff
[DOM] Add unstable_batchedUpdates to server-rendering-stub (#27028)
f2efeae 
`unstable_batchedUpdates` shouldn't really be called on the server but
the semantics are clear enough and we can provide a trivial
implementation that calls the provided callback so we are adding it to
the server-rendering-stub.

This means we will also keep it around when we make the top level
react-dom exports match the server-rendering-stub in the next major

DiffTrain build for commit 1fdacbe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gnoff @react-sizebot @sebmarkbage @facebook-github-bot