Change to content hash for RN canary VERSION strings #28582

kassens · 2024-03-18T23:45:46Z

With this change, the different files in RN will have different hashes. This replaces the git hash and means that the file content (including version) is only updated when the rest of the file content actually changes. This should remove "noop" changes that need to be synced that only update the version string.

A difference to the www implementation here is (and I'd be looking at updating www as well if this lands well) that each file has an individual hash instead of a combined content hash. This further reduces the number of updated files and I couldn't find a reason we need to have these in sync. The best I can gather is that this hash is used so folks don't directly compare version string and make future updates harder.

react-sizebot · 2024-03-18T23:48:45Z

Comparing: 9c75cd5...175a079

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.83 kB	176.83 kB	=	54.91 kB	54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	173.26 kB	173.26 kB	=	54.04 kB	54.04 kB
facebook-www/ReactDOM-prod.classic.js	=	594.27 kB	594.27 kB	=	104.44 kB	104.44 kB
facebook-www/ReactDOM-prod.modern.js	=	577.53 kB	577.53 kB	=	101.47 kB	101.47 kB
test_utils/ReactAllWarnings.js	Deleted	66.63 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	66.63 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Generated by 🚫 dangerJS against 175a079

josephsavona · 2024-03-19T15:09:28Z

This seems fine if it's only updating files that are synced to Meta, rather than files used in OSS. Hard to tell from the code if that's strictly the case.

rickhanlonii · 2024-03-19T20:16:44Z

LGTM, let's just follow up to confirm it doesn't impact the OSS files

In facebook#28582 I missed that experimental files have a copy of this build function setting the version strings.

Also apply content hash for experimental files In #28582 I missed that experimental files have a copy of this build function setting the version strings.

With this change, the different files in RN will have *different* hashes. This replaces the git hash and means that the file content (including version) is only updated when the rest of the file content actually changes. This should remove "noop" changes that need to be synced that only update the version string. A difference to the www implementation here is (and I'd be looking at updating www as well if this lands well) that each file has an individual hash instead of a combined content hash. This further reduces the number of updated files and I couldn't find a reason we need to have these in sync. The best I can gather is that this hash is used so folks don't directly compare version string and make future updates harder.

Also apply content hash for experimental files In facebook#28582 I missed that experimental files have a copy of this build function setting the version strings.

With this change, the different files in RN will have *different* hashes. This replaces the git hash and means that the file content (including version) is only updated when the rest of the file content actually changes. This should remove "noop" changes that need to be synced that only update the version string. A difference to the www implementation here is (and I'd be looking at updating www as well if this lands well) that each file has an individual hash instead of a combined content hash. This further reduces the number of updated files and I couldn't find a reason we need to have these in sync. The best I can gather is that this hash is used so folks don't directly compare version string and make future updates harder. DiffTrain build for commit cb076b5.

Also apply content hash for experimental files In #28582 I missed that experimental files have a copy of this build function setting the version strings. DiffTrain build for commit 37676ab.

…k#28582)" This reverts commit cb076b5.

#29236 caused issues for internal syncs at Meta, because we were computing version numbers using file hashes (to eliminate "no-op" internal sync commits). The problem is that since version numbers may not be consistent across synced files (e.g. if some files have not changed in recent commits), the newly introduced version mismatch check fails. There's some more work that needs to be done here to restore the benefits of file-specific hashing, but for now this simply reverts the content hash changes from the following PRs: - #28633 (95319ab) - #28590 (37676ab) - #28582 (cb076b5) - #26734 (5dd90c5) - #26331 (3cad3a5)

#29236 caused issues for internal syncs at Meta, because we were computing version numbers using file hashes (to eliminate "no-op" internal sync commits). The problem is that since version numbers may not be consistent across synced files (e.g. if some files have not changed in recent commits), the newly introduced version mismatch check fails. There's some more work that needs to be done here to restore the benefits of file-specific hashing, but for now this simply reverts the content hash changes from the following PRs: - #28633 (95319ab) - #28590 (37676ab) - #28582 (cb076b5) - #26734 (5dd90c5) - #26331 (3cad3a5) DiffTrain build for [5bd4031](5bd4031)

#29236 caused issues for internal syncs at Meta, because we were computing version numbers using file hashes (to eliminate "no-op" internal sync commits). The problem is that since version numbers may not be consistent across synced files (e.g. if some files have not changed in recent commits), the newly introduced version mismatch check fails. There's some more work that needs to be done here to restore the benefits of file-specific hashing, but for now this simply reverts the content hash changes from the following PRs: - #28633 (95319ab) - #28590 (37676ab) - #28582 (cb076b5) - #26734 (5dd90c5) - #26331 (3cad3a5) DiffTrain build for commit 5bd4031.

Change to content hash for RN canary VERSION strings

175a079

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 18, 2024

kassens requested review from sammy-SC, acdlite and yungsters March 18, 2024 23:51

rickhanlonii approved these changes Mar 19, 2024

View reviewed changes

kassens merged commit cb076b5 into facebook:main Mar 19, 2024
38 checks passed

kassens deleted the pr28582 branch March 19, 2024 20:16

kassens added a commit to kassens/react that referenced this pull request Mar 19, 2024

Also apply content hash for experimental files

f98f063

In facebook#28582 I missed that experimental files have a copy of this build function setting the version strings.

kassens mentioned this pull request Mar 19, 2024

Also apply content hash for experimental files #28590

Merged

kassens added a commit that referenced this pull request Mar 19, 2024

Also apply content hash for experimental files (#28590)

37676ab

Also apply content hash for experimental files In #28582 I missed that experimental files have a copy of this build function setting the version strings.

ztanner mentioned this pull request Mar 21, 2024

Update React from 6c3b8dbfe to a4939017f vercel/next.js#63413

Closed

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Draft

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

yungsters mentioned this pull request May 30, 2024

Revert Build Versions from Content Hash to Commit Hash #29663

Merged

yungsters added a commit to yungsters/react that referenced this pull request May 30, 2024

Revert "Change to content hash for RN canary VERSION strings (faceboo…

3b15879

…k#28582)" This reverts commit cb076b5.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change to content hash for RN canary VERSION strings #28582

Change to content hash for RN canary VERSION strings #28582

kassens commented Mar 18, 2024 •

edited

Loading

react-sizebot commented Mar 18, 2024

josephsavona commented Mar 19, 2024

rickhanlonii commented Mar 19, 2024

Change to content hash for RN canary VERSION strings #28582

Change to content hash for RN canary VERSION strings #28582

Conversation

kassens commented Mar 18, 2024 • edited Loading

react-sizebot commented Mar 18, 2024

Critical size changes

Significant size changes

josephsavona commented Mar 19, 2024

rickhanlonii commented Mar 19, 2024

kassens commented Mar 18, 2024 •

edited

Loading