Move tail hydration mismatch back to hydration context #28501

sebmarkbage · 2024-03-06T01:00:20Z

In #23176 we added a special case in completeWork for SuspenseBoundaries if they still have trailing children. However, that misses a case because it doesn't log a recoverable error for the hydration mismatch. So we get an error that we rerendered.

I think this special case was done to avoid contexts getting out of sync. I don't know why we didn't just move where the pop happens though so that's what I did here and let the regular pass throw instead. Seems to be pass the tests.

Fixes an issue where no recoverable error is thrown in this case.

react-sizebot · 2024-03-06T01:05:00Z

Comparing: 113ab9a...f20732a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	177.19 kB	177.10 kB	=	55.23 kB	55.19 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	177.72 kB	177.64 kB	=	55.55 kB	55.52 kB
facebook-www/ReactDOM-prod.classic.js	=	594.67 kB	594.36 kB	=	105.04 kB	104.96 kB
facebook-www/ReactDOM-prod.modern.js	=	577.93 kB	577.62 kB	=	102.10 kB	102.01 kB
test_utils/ReactAllWarnings.js	Deleted	66.60 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	66.60 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Generated by 🚫 dangerJS against f20732a

In #23176 we added a special case in completeWork for SuspenseBoundaries if they still have trailing children. However, that misses a case because it doesn't log a recoverable error for the hydration mismatch. So we get an error that we rerendered. I think this special case was done to avoid contexts getting out of sync. I don't know why we didn't just move where the pop happens though so that's what I did here and let the regular pass throw instead. Seems to be pass the tests. DiffTrain build for [c11b196](c11b196)

In facebook#23176 we added a special case in completeWork for SuspenseBoundaries if they still have trailing children. However, that misses a case because it doesn't log a recoverable error for the hydration mismatch. So we get an error that we rerendered. I think this special case was done to avoid contexts getting out of sync. I don't know why we didn't just move where the pop happens though so that's what I did here and let the regular pass throw instead. Seems to be pass the tests.

In #23176 we added a special case in completeWork for SuspenseBoundaries if they still have trailing children. However, that misses a case because it doesn't log a recoverable error for the hydration mismatch. So we get an error that we rerendered. I think this special case was done to avoid contexts getting out of sync. I don't know why we didn't just move where the pop happens though so that's what I did here and let the regular pass throw instead. Seems to be pass the tests. DiffTrain build for commit c11b196.

sebmarkbage requested review from gnoff and acdlite March 6, 2024 01:00

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 6, 2024

Move tail hydration mismatch back to hydration context

f20732a

Fixes an issue where no recoverable error is thrown in this case.

sebmarkbage force-pushed the errortail branch from 6d74e8a to f20732a Compare March 6, 2024 01:01

sebmarkbage mentioned this pull request Mar 6, 2024

Move Hydration Mismatch Errors to Throw or Log Once (Kind of) #28502

Merged

sebmarkbage requested a review from rickhanlonii March 6, 2024 01:51

acdlite approved these changes Mar 6, 2024

View reviewed changes

sebmarkbage merged commit c11b196 into facebook:main Mar 6, 2024
38 checks passed

ztanner mentioned this pull request Mar 18, 2024

Update React from 6c3b8dbfe to a4939017f vercel/next.js#63413

Closed

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Draft

ztanner mentioned this pull request Apr 2, 2024

Update React from 14898b6a9 to a870b2d54 vercel/next.js#63976

Closed

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move tail hydration mismatch back to hydration context #28501

Move tail hydration mismatch back to hydration context #28501

sebmarkbage commented Mar 6, 2024

react-sizebot commented Mar 6, 2024 •

edited

Move tail hydration mismatch back to hydration context #28501

Move tail hydration mismatch back to hydration context #28501

Conversation

sebmarkbage commented Mar 6, 2024

react-sizebot commented Mar 6, 2024 • edited

Critical size changes

Significant size changes

react-sizebot commented Mar 6, 2024 •

edited