[Test] Update `flushSync` tests to use react-dom #28490

gnoff · 2024-03-05T03:19:40Z

Updates the flushSync tests to use react-dom instead of ReactNoop. flushSync is primarily a react-dom API and asserting the implementation of ReactNoop is not really ideal especially since we are going to be refactoring flushSync soon to not be implemented in the reconciler internals.

ReactNoop still have a flushSync api and it can still be used in other tests that are primarily about testing other functionlity and use ReactNoop as the renderer.

react-sizebot · 2024-03-05T03:22:53Z

Comparing: 113ab9a...012445d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	177.19 kB	177.19 kB	=	55.23 kB	55.23 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	177.72 kB	177.72 kB	=	55.55 kB	55.55 kB
facebook-www/ReactDOM-prod.classic.js	=	594.67 kB	594.67 kB	=	105.04 kB	105.04 kB
facebook-www/ReactDOM-prod.modern.js	=	577.93 kB	577.93 kB	=	102.10 kB	102.10 kB
test_utils/ReactAllWarnings.js	Deleted	66.60 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	66.60 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Generated by 🚫 dangerJS against 012445d

Updates the FlushSync tests to use react-dom instead of ReactNoop. flushSync is primarily a react-dom API and asserting the implementation of ReactNoop is not really ideal especially since we are going to be refactoring flushSync soon to not be implemented in the reconciler internals. ReactNoop still have a flushSync api and it can still be used in other tests that are primarily about testing other functionlity and use ReactNoop as the renderer.

rickhanlonii · 2024-03-05T05:04:14Z

packages/react-reconciler/src/__tests__/ReactFlushSync-test.js

@@ -72,7 +117,7 @@ describe('ReactFlushSync', () => {
        await waitForPaint(['1, 1']);
      }
    });
-    expect(root).toMatchRenderedOutput('1, 1');
+    expect(getVisibleChildren(container)).toEqual('1, 1');


What do you think about creating a matcher for this? Seems common and we're starting to copy this helper over to multiple places. It would be nice to standardize the ReactDOM tests asserting container content on one patter because it's all over the place right now

Yeah it's generally very useful however there are some special cases in ReactDOMFloat tests where we do even more special casing because we need to assert certain things like scripts which the basic version of this ignores. Maybe instead of a matcher we just have a test util for this function so it's a little clearer what's happening when you choose to specialize the implementation. Or maybe the float one can be made the default one

rickhanlonii · 2024-03-05T05:05:23Z

packages/react-reconciler/src/__tests__/ReactFlushSync-test.js

    });
  });

-  test('do not flush passive effects synchronously after render in legacy mode', async () => {
+  // @gate !disableLegacyMode


woah SICK YES

Updates the `flushSync` tests to use react-dom instead of ReactNoop. flushSync is primarily a react-dom API and asserting the implementation of ReactNoop is not really ideal especially since we are going to be refactoring flushSync soon to not be implemented in the reconciler internals. ReactNoop still have a flushSync api and it can still be used in other tests that are primarily about testing other functionlity and use ReactNoop as the renderer.

Updates the `flushSync` tests to use react-dom instead of ReactNoop. flushSync is primarily a react-dom API and asserting the implementation of ReactNoop is not really ideal especially since we are going to be refactoring flushSync soon to not be implemented in the reconciler internals. ReactNoop still have a flushSync api and it can still be used in other tests that are primarily about testing other functionlity and use ReactNoop as the renderer. DiffTrain build for commit 0ae2b13.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 5, 2024

gnoff requested a review from acdlite March 5, 2024 03:19

gnoff force-pushed the convert-flush-sync-test branch from 78c05a8 to 012445d Compare March 5, 2024 03:24

rickhanlonii approved these changes Mar 5, 2024

View reviewed changes

gnoff merged commit 0ae2b13 into facebook:main Mar 5, 2024
38 checks passed

gnoff deleted the convert-flush-sync-test branch March 5, 2024 05:40

ztanner mentioned this pull request Mar 18, 2024

Update React from 6c3b8dbfe to a4939017f vercel/next.js#63413

Closed

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Draft

ztanner mentioned this pull request Apr 2, 2024

Update React from 14898b6a9 to a870b2d54 vercel/next.js#63976

Closed

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Test] Update `flushSync` tests to use react-dom #28490

[Test] Update `flushSync` tests to use react-dom #28490

gnoff commented Mar 5, 2024

react-sizebot commented Mar 5, 2024 •

edited

rickhanlonii Mar 5, 2024 •

edited

gnoff Mar 5, 2024

rickhanlonii Mar 5, 2024

[Test] Update flushSync tests to use react-dom #28490

[Test] Update flushSync tests to use react-dom #28490

Conversation

gnoff commented Mar 5, 2024

react-sizebot commented Mar 5, 2024 • edited

Critical size changes

Significant size changes

rickhanlonii Mar 5, 2024 • edited

Choose a reason for hiding this comment

gnoff Mar 5, 2024

Choose a reason for hiding this comment

rickhanlonii Mar 5, 2024

Choose a reason for hiding this comment

[Test] Update `flushSync` tests to use react-dom #28490

[Test] Update `flushSync` tests to use react-dom #28490

react-sizebot commented Mar 5, 2024 •

edited

rickhanlonii Mar 5, 2024 •

edited