Codemod tests from createClass to ES2015 classes #7321

keyz · 2016-07-20T20:57:02Z

Codemodded automatically using https://github.com/reactjs/react-codemod#explanation-of-the-new-es2015-class-transform-with-property-initializers.

Reviewers: @sebmarkbage @spicyj

codemod log:

$ ../react-codemod/node_modules/.bin/jscodeshift -t ./transforms/class.js --mixin-module-name=ReactComponentWithPureRenderMixin --flow=true --pure-component=false --explicit-require=false ./src
Processing 343 files...
Spawning 7 workers...
Sending 49 files to free worker...
Sending 49 files to free worker...
Sending 49 files to free worker...
Sending 49 files to free worker...
Sending 49 files to free worker...
Sending 49 files to free worker...
Sending 49 files to free worker...
./src/renderers/dom/server/__tests__/ReactServerRendering-test.js: `Bar` was skipped because of deprecated API calls. Remove calls to getDOMNode, isMounted, replaceProps, replaceState, setProps in your React component and re-run this script.
./src/renderers/dom/client/__tests__/ReactMount-test.js: `Component` was skipped because of invalid field(s) `componentDidMount, componentWillUnmount` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/addons/__tests__/ReactComponentWithPureRenderMixin-test.js: `Apple` was skipped because of inconvertible mixins.
./src/addons/__tests__/ReactComponentWithPureRenderMixin-test.js: `Component` was skipped because of inconvertible mixins.
./src/renderers/shared/stack/reconciler/__tests__/ReactComponentLifeCycle-test.js: `Component` was skipped because of deprecated API calls. Remove calls to getDOMNode, isMounted, replaceProps, replaceState, setProps in your React component and re-run this script.
./src/addons/transitions/ReactCSSTransitionGroupChild.js: `ReactCSSTransitionGroupChild` was skipped because of deprecated API calls. Remove calls to getDOMNode, isMounted, replaceProps, replaceState, setProps in your React component and re-run this script.
./src/renderers/shared/stack/reconciler/__tests__/ReactComponentLifeCycle-test.js: `Component` was skipped because of deprecated API calls. Remove calls to getDOMNode, isMounted, replaceProps, replaceState, setProps in your React component and re-run this script.
./src/renderers/shared/stack/reconciler/__tests__/ReactComponentLifeCycle-test.js: `Component` was skipped because of deprecated API calls. Remove calls to getDOMNode, isMounted, replaceProps, replaceState, setProps in your React component and re-run this script.
./src/renderers/shared/stack/reconciler/__tests__/ReactComponentLifeCycle-test.js: `Outer` was skipped because of invalid field(s) `componentWillMount, componentDidMount, componentWillReceiveProps, shouldComponentUpdate, componentWillUpdate, componentDidUpdate, componentWillUnmount` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/shared/stack/reconciler/__tests__/ReactComponentLifeCycle-test.js: `Inner` was skipped because of invalid field(s) `componentWillMount, componentDidMount, componentWillReceiveProps, shouldComponentUpdate, componentWillUpdate, componentDidUpdate, componentWillUnmount` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/test/__tests__/ReactTestUtils-test.js: `SomeComponent` was skipped because of invalid field(s) `componentWillUnmount` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/addons/link/__tests__/LinkedStateMixin-test.js: `Component` was skipped because of inconvertible mixins.
./src/renderers/shared/devtools/__tests__/ReactComponentTreeDevtool-test.js: `Anon` was skipped because of invalid field(s) `render` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/shared/devtools/__tests__/ReactComponentTreeDevtool-test.js: `Orange` was skipped because of invalid field(s) `render` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/art/ReactART.js: `Surface` was skipped because of inconvertible mixins.
./src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js: `Row` was skipped because of invalid field(s) `render` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js: `FancyRow` was skipped because of invalid field(s) `render` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js: `Viz1` was skipped because of invalid field(s) `render` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js: `App1` was skipped because of invalid field(s) `render` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js: `Viz2` was skipped because of invalid field(s) `render` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js: `App2` was skipped because of invalid field(s) `render` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/shared/stack/reconciler/__tests__/ReactCompositeComponentState-test.js: `` was skipped because of deprecated API calls. Remove calls to getDOMNode, isMounted, replaceProps, replaceState, setProps in your React component and re-run this script.
./src/renderers/shared/__tests__/ReactPerf-test.js: `` was skipped because of invalid field(s) `shouldComponentUpdate, componentWillMount, componentDidMount, componentWillReceiveProps, componentWillUpdate, componentDidUpdate, componentWillUnmount, render` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/shared/stack/reconciler/__tests__/ReactMultiChild-test.js: `MockComponent` was skipped because of invalid field(s) `componentDidMount, componentDidUpdate, componentWillUnmount` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/shared/stack/reconciler/__tests__/ReactMultiChild-test.js: `MockComponent` was skipped because of invalid field(s) `componentDidMount, componentWillUnmount` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/shared/stack/reconciler/__tests__/ReactMultiChild-test.js: `MockComponent` was skipped because of invalid field(s) `componentDidMount, componentWillUnmount` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/shared/stack/reconciler/__tests__/ReactMultiChild-test.js: `MockComponent` was skipped because of invalid field(s) `componentDidMount, componentWillUnmount` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/shared/stack/reconciler/__tests__/ReactStateSetters-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClass-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactBindOptout-test.js: `TestBindComponent` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactBindOptout-test.js: `TestBindComponent` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactBindOptout-test.js: `TestBindComponent` was skipped because of invalid field(s) `onMouseEnter, onMouseLeave, onClick` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/isomorphic/classic/class/__tests__/ReactBindOptout-test.js: `TestBindComponent` was skipped because of invalid field(s) `onClick, badIdeas` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/isomorphic/classic/class/__tests__/ReactBind-test.js: `TestBindComponent` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactBind-test.js: `TestBindComponent` was skipped because of invalid field(s) `onMouseEnter, onMouseLeave, onClick, badIdeas` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/renderers/shared/stack/reconciler/__tests__/ReactUpdates-test.js: `Box` was skipped because of inconvertible mixins.
./src/renderers/shared/stack/reconciler/__tests__/ReactUpdates-test.js: `Child` was skipped because of inconvertible mixins.
./src/renderers/shared/stack/reconciler/__tests__/ReactUpdates-test.js: `Switcher` was skipped because of inconvertible mixins.
./src/renderers/shared/stack/reconciler/__tests__/ReactUpdates-test.js: `App` was skipped because of inconvertible mixins.
./src/isomorphic/classic/element/__tests__/ReactElement-test.js: `Component` was skipped because of invalid field(s) `render` on the React component. Remove any right-hand-side expressions that are not simple, like: `componentWillUpdate: createWillUpdate()` or `render: foo ? renderA : renderB`.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `Component` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `Component` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `Component` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `Component` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `Component` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `Component` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
./src/isomorphic/classic/class/__tests__/ReactClassMixin-test.js: `` was skipped because of inconvertible mixins.
All done.
Results:
0 errors
0 unmodified
289 skipped
54 ok
Time elapsed: 8.729seconds

Then I reverted some non-test files and things under ./src/isomorphic/classic/class.

sophiebits · 2016-07-20T20:59:53Z

Just 10 files? We have 53 that have createClass in them…

keyz · 2016-07-20T21:12:01Z

@spicyj oops, I forgot to turn off explicit-require. ~~We require 'React' instead of 'react' in our tests.~~

sophiebits · 2016-07-20T21:13:59Z

Is it because we usually require in beforeEach instead of at the top level?

keyz · 2016-07-21T07:41:50Z

@spicyj yeah, I was wrong -- our codemod only searches for variable declarators and ES6 imports but not assignments (https://github.com/reactjs/react-codemod/blob/master/transforms/utils/ReactUtils.js#L28).

I re-ran the codemod and updated the PR. There are some failing tests and they'll be fixed by #7326 and babel/babel#3589.

sophiebits · 2016-07-22T02:48:48Z

Accepting, feel free to merge when the babel stuff is sorted out.

sebmarkbage · 2016-07-22T05:44:31Z

This is really exciting!

- babel/babel#3589 fixed inferring class name

- reverted more files under classic

Codemod tests from createClass to ES2015 classes (cherry picked from commit 484f96b)

Refs facebook#7321

ref. facebook#7321

ref. #7321

ref. facebook#7321

ref. #7321 (cherry picked from commit df03318)

ghost added GH Review: review-needed CLA Signed labels Jul 20, 2016

ghost added the CLA Signed label Jul 20, 2016

keyz force-pushed the codemod-es6-component branch from 3bd05c3 to f4fe06a Compare July 21, 2016 07:36

ghost added the CLA Signed label Jul 21, 2016

keyz force-pushed the codemod-es6-component branch from f4fe06a to 43f55c8 Compare July 21, 2016 21:09

ghost added the CLA Signed label Jul 21, 2016

sophiebits added GH Review: accepted and removed GH Review: review-needed labels Jul 22, 2016

ghost added the CLA Signed label Jul 22, 2016

keyz force-pushed the codemod-es6-component branch from de6bb6e to 61b14f9 Compare July 23, 2016 22:05

facebook-github-bot added the CLA Signed label Jul 23, 2016

Keyan Zhang added 2 commits July 23, 2016 15:16

upgraded babel-plugin-transform-class-properties

bf26e70

- babel/babel#3589 fixed inferring class name

codemodded tests from createClass to ES2015 classes

4d8a5bc

- reverted more files under classic

keyz force-pushed the codemod-es6-component branch from 61b14f9 to 4d8a5bc Compare July 23, 2016 22:16

keyz merged commit 484f96b into facebook:master Jul 23, 2016

keyz deleted the codemod-es6-component branch July 23, 2016 23:37

zpao added the semver-exempt label Aug 12, 2016

zpao modified the milestones: 15-next, 15.3.1 Aug 12, 2016

zpao pushed a commit that referenced this pull request Aug 12, 2016

Merge pull request #7321 from keyanzhang/codemod-es6-component

3c7f275

Codemod tests from createClass to ES2015 classes (cherry picked from commit 484f96b)

koba04 added a commit to koba04/react that referenced this pull request Sep 8, 2016

Run codemode react-codemod/transforms/class again

4cd6e72

Refs facebook#7321

koba04 added a commit to koba04/react that referenced this pull request Sep 8, 2016

Run codemod react-codemod/transforms/class again

cc15dbe

ref. facebook#7321

koba04 mentioned this pull request Sep 8, 2016

Move from createClass to ES classes using react-codemod/transforms/class #7679

Merged

sophiebits pushed a commit that referenced this pull request Sep 8, 2016

Run codemod react-codemod/transforms/class again (#7679)

df03318

ref. #7321

acdlite pushed a commit to acdlite/react that referenced this pull request Sep 9, 2016

Run codemod react-codemod/transforms/class again (facebook#7679)

0c137b5

ref. facebook#7321

zpao pushed a commit that referenced this pull request Oct 4, 2016

Run codemod react-codemod/transforms/class again (#7679)

747d651

ref. #7321 (cherry picked from commit df03318)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Codemod tests from createClass to ES2015 classes #7321

Codemod tests from createClass to ES2015 classes #7321

keyz commented Jul 20, 2016 •

edited

Loading

sophiebits commented Jul 20, 2016

keyz commented Jul 20, 2016 •

edited

Loading

sophiebits commented Jul 20, 2016

keyz commented Jul 21, 2016

sophiebits commented Jul 22, 2016

sebmarkbage commented Jul 22, 2016

Codemod tests from createClass to ES2015 classes #7321

Codemod tests from createClass to ES2015 classes #7321

Conversation

keyz commented Jul 20, 2016 • edited Loading

sophiebits commented Jul 20, 2016

keyz commented Jul 20, 2016 • edited Loading

sophiebits commented Jul 20, 2016

keyz commented Jul 21, 2016

sophiebits commented Jul 22, 2016

sebmarkbage commented Jul 22, 2016

keyz commented Jul 20, 2016 •

edited

Loading

keyz commented Jul 20, 2016 •

edited

Loading