Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove loose check on non-number controlled inputs. Fix trailing dot issue. #9584
In #7359 I added a loose check before assigning the
So that created an issue: #9561
This commit removes that loose check, adds tests for the associated cases, and updates old tests to be in line with the new expectation. I also added a new DOM test fixture and updated the input DOM fixtures to use the new format we're using in other tests.
@aweary Good thought. For the time being, I've just added an extra bit to the build script to copy over
Good call too! The strict equality check totally did it.
I ran through the fixtures for text and number inputs in Chrome, Firefox, Safari, IE11, and Edge. Everything seems to be working great!
We need to include a
requestAnimationFrame polyfill to test in older browsers, but I think we can do that in a follow-up.
I agree - this would be good to get into the 15.6 release. I'll cherry-pick it.
Also "We need to include a requestAnimationFrame polyfill to test in older browsers, but I think we can do that in a follow-up." - I'm not seeing any use of 'requestAnimationFrame' in these changes, is there still a need for a polyfill there?
I didn't want to merge until I was clear on how including this in 15.6 was handled.
Nothing specific to these changes, Fiber requires