-
Notifications
You must be signed in to change notification settings - Fork 46.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Fire: Modernizing React DOM #13525
Comments
I love this. Reducing bundle size and the "class" prop are changes that will be very welcome. Great work! |
🙂 |
Attention form library authors! 🤣 |
Great! |
className → class is fantastic What about all the others? Seems weird to still be doing |
Adopting |
This is awesome. I'm so curious how the move to Seems like |
This is fantastic news, thanks @gaearon! |
I love every of these points, except the |
Fantastic! Do you have a goal for bundle size reduction? |
👏 |
I’m open to discussion but I’d argue these changes aren’t worth it (except |
I think a re-write of the event system is the most interesting aspect of this. There is significant opportunity to reduce the bundle size and ease community contributions. Let's do it! |
I wonder if it would be worthwhile to also work on releasing JSX 2.0 at the same time? People are going to need to re-learn a handful of things anyway. Maybe it's better to have to re-learn a bunch at one time rather than a few things twice over a period of time? Just a thought that occurred as I read this. |
And yet if we pass an unknown key/value pair it will be treated as an attribute since React 16. So we’re already inconsistent. Also, my comment was about users being wrong in expecting React to set I’ve defended your side of this argument for years but I think now that this is friction that’s just not worth it. You don’t gain anything from it. Just letting people use |
As long as React Fire is blazing fast.... 👍 |
These changes are all fantastic. I'm way excited about this and its implications for I'd love to provide feedback on this as it's being implemented. |
We considered this but think this might be an oversimplification. Event delegation lets us avoid setting up a bunch of listeners for every node on the initial render. And swapping them on updates. Those aspects shouldn’t be ignored. There is likely more benchmarking to be done there though. |
@tannerlinsley It would be super, super nice if |
Dropping a third of React DOM would be nice. We’ll see. It’s hard to say early but we’ll do our best. |
Wow, this is an enumeration of almost all the design decisions I mention when people ask me about React cons. Love the direction this is going. |
What would the upgrade path be for libraries that use |
@gaearon Maybe it's not a big deal, today its nice to say "props are DOM properties not HTML attributes", now it'll be "except className, that one is the HTML name". I'd also like to be able to copy/paste SVG w/o 10 minutes of messing around with attributes to match up with React's |
What about |
It feels like the The rest of the changes seem relatively low risk from an ecosystem point of view, but getting rid of |
I agree with @felixfbecker Beeing able to deconstruct all properties but one would certainly cause more confusion and be harder to explain to new users than that they need to use className because class is a keyword (which they can clearly see when the misstake is made, as it's colored differently). Working around class in deconstructing requires introducing new syntax or a completely different way to read out that specific property that would only work untill you need to use a rest property. |
@felixfbecker it could it be <label class="foo" for="bar">..</label> would be React.createElement('label', {className: 'foo', htmlFor: 'bar'}, '..') |
Great plan! Nice to here that! 👏👏👏 |
@jonathantneal Yes, the new system heavily use Pointer Events – with fallbacks to Mouse/Touch events when there's no support for Pointer Events. |
I am concerned that #11347 was not addressed in this issue. React flunks https://custom-elements-everywhere.com. |
In this update: #13525 (comment) @gaearon mentions:
I was curious if a list of these edge cases are documented anywhere? |
@gaearon now that Flare has gone out (SCNR), is there an updated plan (regarding the June 5th, 2019 update) how to proceed? And like @trusktr, I also would like to get #11347 addressed here. |
Could be split polyfills into another bundle especially the one not relevant to major evergreen browsers. |
Hey all, it's been a while and we've tried some of these things on and off. Let me give an update on each:
We still want to do this, but we've decided to "reserve" React 17 to have minimal possible breaking changes so that it can focus on the next item on this list. So this change will wait until React 18.
We're doing this in React 17. This turned out to be a huge chunk of work but thankfully it's finished.
We'll likely come back to this but it's unclear how much churn is worth doing here. So this is still TBD.
We've tried this early in 2019, and a truly minimal event system did not work out very well in our internal testing. There was quite a bit of cross-browser normalization React is doing that is still useful for people with older browsers, or in more niche areas like rich text input editors using
This was the most controversial part of the proposal. Since then, we released Hooks, which encourage writing function components. In function components, we generally suggest using destructuring for props, but you can't write |
Hi, it's a great article! Any Idea when can we see such changes? |
@morevolk-latei In your measurements, how much time is spent parsing 100 KB of ReactDOM? |
For latest status, see an update from June 5th, 2019: #13525 (comment)
This year, the React team has mostly been focused on fundamental improvements to React.
As this work is getting closer to completion, we're starting to think of what the next major releases of React DOM should look like. There are quite a few known problems, and some of them are hard or impossible to fix without bigger internal changes.
We want to undo past mistakes that caused countless follow-up fixes and created much technical debt. We also want to remove some of the abstraction in the event system which has been virtually untouched since the first days of React, and is a source of much complexity and bundle size.
We're calling this effort "React Fire".
🔥 React Fire
React Fire is an effort to modernize React DOM. Our goal is to make React better aligned with how the DOM works, revisit some controversial past decisions that led to problems, and make React smaller and faster.
We want to ship this set of changes in a future React major release because some of them will unfortunately be breaking. Nevertheless, we think they're worth it. And we have more than 50 thousands components at Facebook to keep us honest about our migration strategy. We can't afford to rewrite product code except a few targeted fixes or automated codemods.
Strategy
There are a few different things that make up our current plan. We might add or remove something but here's the thinking so far:
Stop reflecting input values in the
value
attribute (Stop syncing value attribute for controlled inputs #11896). This was originally added in React 15.2.0 via Properly set value and defaultValue for input and textarea #6406. It was very commonly requested because people's conceptual model of the DOM is that thevalue
they see in the DOM inspector should match thevalue
JSX attribute. But that's not how the DOM works. When you type into a field, the browser doesn't update thevalue
attribute. React shouldn't do it either. It turned out that this change, while probably helpful for some code relying on CSS selectors, caused a cascade of bugs — some of them still unfixed to this day. Some of the fallout from this change includes: Form submit button has empty values in 15.2.0 #7179, Firefox validation triggers on input component render #8395, IE 11 and Edge no longer prompt to remember password on controlled form #7328, Date input with defaultValue regression in 15.2 #7233, backspace fails to clear values on input type='email' #11881, Bug: Backspace in input type="number" behaves badly in Blink #7253, Remove loose check on non-number controlled inputs. Fix trailing dot issue. #9584, Inputs should not mutate value on type conversion (when they stringify to the same thing) #9806, [#9712] fix <input type="number" /> value '.98' should not be equal to '0.98'. #9714, Use defaultValue instead of setAttribute('value') #11534, Use the same value synchronization function on number blur #11746, Do not assign node.value on input creation if no change will occur #12925. At this point it's clearly not worth it to keep fighting the browser, and we should revert it. The positive part of this journey is that thanks to tireless work from our DOM contributors (@nhunzaker, @aweary, @jquense, and @philipp-spiess) we now have detailed DOM test fixtures that will help us avoid regressions.Attach events at the React root rather than the document (Attach event per react container root, rather than on the document #2043). Attaching event handlers to the document becomes an issue when embedding React apps into larger systems. The Atom editor was one of the first cases that bumped into this. Any big website also eventually develops very complex edge cases related to
stopPropagation
interacting with non-React code or across React roots (Native event.stopPropagation outside of React root cuts out React events #8693, Attach event listeners at the root of the tree instead of document #8117, Event listener attached todocument
will still be called after callingevent.stopPropagation()
#12518). We will also want to attach events eagerly to every root so that we can do less runtime checks during updates.Migrate from
onChange
toonInput
and don’t polyfill it for uncontrolled components ([RFC] onChange -> onInput, and don't polyfill onInput for uncontrolled components #9657). See the linked issue for a detailed plan. It has been confusing that React uses a different event name for what's known asinput
event in the DOM. While we generally avoid making big changes like this without significant benefit, in this case we also want to change the behavior to remove some complexity that's only necessary for edge cases like mutating controlled inputs. So it makes sense to do these two changes together, and use that as an opportunity to makeonInput
andonChange
work exactly how the DOM events do for uncontrolled components.Drastically simplify the event system (Play Nicely with The DOM Event System (because it's legacy anyway) #4751). The current event system has barely changed since its initial implementation in 2013. It is reused across React DOM and React Native, so it is unnecessarily abstract. Many of the polyfills it provides are unnecessary for modern browsers, and some of them create more issues than they solve. It also accounts for a significant portion of the React DOM bundle size. We don't have a very specific plan here, but we will probably fork the event system completely, and then see how minimal we can make it if we stick closer to what the DOM gives us. It's plausible that we'll get rid of synthetic events altogether. We should stop bubbling events like media events which don’t bubble in the DOM and don’t have a good reason to bubble. We want to retain some React-specific capabilities like bubbling through portals, but we will attempt to do this via simpler means (e.g. re-dispatching the event). Passive events will likely be a part of this.
className
→class
(Why are attribute names "class" and "for" discouraged? #4331, see also React Fire: Modernizing React DOM #13525 (comment) below). This has been proposed countless times. We're already allowing passingclass
down to the DOM node in React 16. The confusion this is creating is not worth the syntax limitations it's trying to protect against. We wouldn't do this change by itself, but combined with everything else above it makes sense. Note we can’t just allow both without warnings because this makes it very difficult for a component ecosystem to handle. Each component would need to learn to handle both correctly, and there is a risk of them conflicting. Since many components processclassName
(for example by appending to it), it’s too error-prone.Tradeoffs
We can't make some of these changes if we aim to keep exposing the current private React event system APIs for projects like React Native Web. However, React Native Web will need a different strategy regardless because React Fabric will likely move more of the responder system to the native side.
We may need to drop compatibility with some older browsers, and/or require more standalone polyfills for them. We still care about supporting IE11 but it's possible that we will not attempt to smooth over some of the existing browser differences — which is the stance taken by many modern UI libraries.
Rollout Plan
At this stage, the project is very exploratory. We don't know for sure if all of the above things will pan out. Because the changes are significant, we will need to dogfood them at Facebook, and try them out in a gradual fashion. This means we'll introduce a feature flag, fork some of the code, and keep it enabled at Facebook for a small group of people. The open source 16.x releases will keep the old behavior, but on master you will be able to run it with the feature flag on.
I plan to work on the project myself for the most part, but I would very much appreciate more discussion and contributions from @nhunzaker, @aweary, @jquense, and @philipp-spiess who have been stellar collaborators and have largely steered React DOM while we were working on Fiber. If there's some area you're particularly interested in, please let me know and we'll work it out.
There are likely things that I missed in this plan. I'm very open to feedback, and I hope this writeup is helpful.
The text was updated successfully, but these errors were encountered: