Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run build fails on master #1482

Closed
crismali opened this issue Dec 18, 2016 · 1 comment
Closed

npm run build fails on master #1482

crismali opened this issue Dec 18, 2016 · 1 comment

Comments

@crismali
Copy link

Steps to reproduce

  1. git clone git@github.com:facebook/relay.git
  2. cd relay
  3. yarn install

npm run build/gulp is run as part of the post-install and fails with:

stream.js:74
      throw er; // Unhandled stream error in pipe.
      ^
Error: ./lib/deepFreeze.js
Module not found: Error: Cannot resolve 'file' or 'directory' ./babel-runtime/core-js/object/is-frozen in /Users/Michael/Development/relay/lib
resolve file
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen.webpack.js doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen.web.js doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen.js doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen.json doesn't exist
resolve directory
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen doesn't exist (directory default file)
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen/package.json doesn't exist (directory description file)
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen.webpack.js]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen.web.js]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen.js]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/object/is-frozen.json]
 @ ./lib/deepFreeze.js 22:40-91./lib/deepFreeze.js
Module not found: Error: Cannot resolve 'file' or 'directory' ./babel-runtime/core-js/object/get-own-property-names in /Users/Michael/Development/relay/lib
resolve file
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names.webpack.js doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names.web.js doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names.js doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names.json doesn't exist
resolve directory
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names doesn't exist (directory default file)
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names/package.json doesn't exist (directory description file)
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names.webpack.js]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names.web.js]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names.js]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/object/get-own-property-names.json]
 @ ./lib/deepFreeze.js 24:51-115./lib/RelayGraphQLTag.js
Module not found: Error: Cannot resolve 'file' or 'directory' ./babel-runtime/core-js/weak-map in /Users/Michael/Development/relay/lib
resolve file
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map.webpack.js doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map.web.js doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map.js doesn't exist
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map.json doesn't exist
resolve directory
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map doesn't exist (directory default file)
  /Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map/package.json doesn't exist (directory description file)
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map.webpack.js]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map.web.js]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map.js]
[/Users/Michael/Development/relay/lib/babel-runtime/core-js/weak-map.json]
 @ ./lib/RelayGraphQLTag.js 17:39-82

Before it fails it displays some warnings as well:

        You or one of the Babel plugins you are using are using Flow declarations as bindings.
        Support for this will be removed in version 6.8. To find out the caller, grep for this
        message and change it to a `console.trace()`.


        You or one of the Babel plugins you are using are using Flow declarations as bindings.
        Support for this will be removed in version 6.8. To find out the caller, grep for this
        message and change it to a `console.trace()`.

A regular npm run build fails in the same way. npm run build works at the v0.10.0 tag but outputs the same warnings.

I know in the contributing guide it says that master is unsafe but that seems to be more geared towards API stability rather than just flat out not being able to build.

@josephsavona
Copy link
Contributor

Thanks for reporting this. You're correct that in general we try to keep master building cleanly. At the moment we're iterating quickly on the core and so things are likely to break briefly while we sort through configuration in different environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants