Skip to content

Commit

Permalink
Fix a bug that occur when plugin pkg-config requirements are empty (#…
Browse files Browse the repository at this point in the history
…9238)

Summary:
Fix a bug introduced by #9198. The bug is triggered when a plugin does not provide any pkg-config requirements.

Pull Request resolved: #9238

Reviewed By: riversand963

Differential Revision: D32771406

Pulled By: ajkr

fbshipit-source-id: 79301871a8bf4e624d5e5eb9d219d7f13948c64d
  • Loading branch information
metaspace authored and facebook-github-bot committed Dec 21, 2021
1 parent 393fc23 commit 2e51b33
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ ROCKSDB_PLUGIN_PKGCONFIG_REQUIRES = $(foreach plugin, $(ROCKSDB_PLUGINS), $($(pl
PLATFORM_LDFLAGS += $(foreach plugin, $(ROCKSDB_PLUGINS), $($(plugin)_LDFLAGS))
CXXFLAGS += $(foreach plugin, $(ROCKSDB_PLUGINS), $($(plugin)_CXXFLAGS))

ifneq ($(ROCKSDB_PLUGIN_PKGCONFIG_REQUIRES),)
ifneq ($(strip $(ROCKSDB_PLUGIN_PKGCONFIG_REQUIRES)),)
LDFLAGS := $(LDFLAGS) $(shell pkg-config --libs $(ROCKSDB_PLUGIN_PKGCONFIG_REQUIRES))
ifneq ($(.SHELLSTATUS),0)
$(error pkg-config failed)
Expand Down

0 comments on commit 2e51b33

Please sign in to comment.