-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow plugins to add pkg-config dependencies to rocksdb.pc #9198
Conversation
This patch fixes an issue that occur when dependencies of plugins are not installed to the same prefix as librocksdb. Because plugin dependencies are declared in the `Libs` field of rocksdb.pc, programs that link against librocksdb with `pkg-config --libs rocksdb` will link with `-L` flag for the path of librocksdb only. This patch allows plugin dependencies to be declared in the `Requires` field of rocksdb.pc, so that pkg-config will correctly provide `-L` flags for dependencies of plugins that are installed in other locations. Signed-off-by: Andreas Hindborg <andreas.hindborg@wdc.com>
0c4a04c
to
fcae19f
Compare
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@metaspace this PR causes the following command to break on my devserver
Could you take a look? |
Yes, will have a look asap. |
@metaspace oh btw, when testing, maybe the command to use is
that's because hdfs is not a plugin yet. |
@metaspace has updated the pull request. You must reimport the pull request before landing. |
Missed a space in a string that was supposed to be empty. Pushed a fix as a separate commit to this PR. |
Signed-off-by: Andreas Hindborg <andreas.hindborg@wdc.com>
Sorry for the confusion. We only support merging once per PR. Are you able to open a new PR? |
Sure. New PR in #9238. Sorry for the mess. |
This patch fixes an issue that occur when dependencies of plugins are not
installed to the same prefix as librocksdb. Because plugin dependencies are
declared in the
Libs
field of rocksdb.pc, programs that link againstlibrocksdb with
pkg-config --libs rocksdb
will link with-L
flag for thepath of librocksdb only. This patch allows plugin dependencies to be declared in
the
Requires
field of rocksdb.pc, so that pkg-config will correctly provide-L
flags for dependencies of plugins that are installed in other locations.