Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error: comparison of integers of different signs: 'const unsigned long long' and 'const long long' [-Werror,-Wsign-compare] #258

Closed
ryandesign opened this issue Sep 2, 2014 · 0 comments
Closed

error: comparison of integers of different signs: 'const unsigned long long' and 'const long long' [-Werror,-Wsign-compare] #258

ryandesign opened this issue Sep 2, 2014 · 0 comments

Comments

@ryandesign
Copy link

rocksdb 3.4 fails to build:

util/benchharness.cc:211:17: error: comparison of integers of different signs: 'const unsigned long long' and 'const long long' [-Werror,-Wsign-compare]
      if (nsecs < minNanoseconds) {
          ~~~~~ ^ ~~~~~~~~~~~~~~
1 error generated.
@somnathr somnathr mentioned this issue Aug 28, 2016
Closed
Nazgolze pushed a commit to Nazgolze/rocksdb-1 that referenced this issue Sep 21, 2021
@ralphtheninja
Merge pull request facebook#258 from Level/travis
25506ea 
remove unsupported versions
Little-Wallace pushed a commit to Little-Wallace/rocksdb that referenced this issue Dec 24, 2021
@tabokie
Revert facebook#252 and disable ignore_unknown_options only for lower…
10fcdb2 
… version (facebook#258)

* Revert "Add an option to disable write stall (facebook#251) (facebook#252)"

This reverts commit 32b29a1.

Signed-off-by: tabokie <xy.tao@outlook.com>

* use ignore_unknown_options regardless of RocksDB version

Signed-off-by: tabokie <xy.tao@outlook.com>

* disable only for lower version and fix test

Signed-off-by: tabokie <xy.tao@outlook.com>
luky116 pushed a commit to luky116/rocksdb that referenced this issue Jul 10, 2024
@seckcoder
[sys-4930] log number shouldn't go backwards (facebook#258)
8026c29 
For current way of setting log number when applying manifest write, the log number could go backwards. Considering following sequence of events:

kMemtableSwitch with log number L
kMemtableSwitch with log number L+1
kManifestWrite with log number L (related to the first memtable switch)
If this is a follower and it takes over right after applying the manifest write, the alive log number will go backwards and be smaller than min_log_number_to_keep. This will cause all log numbers in alive_log_files_ to be pruned.

So we should only set the log number if it's strictly greater than existing alive log number. We don't need to do this for memtable switch though. Memtable switch should never set it to smaller value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryandesign