Fix candidate file comparison when using path ids #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lol, nice catch :) |
igorcanadi
added a commit
that referenced
this pull request
Aug 31, 2014
Fix candidate file comparison when using path ids
|
Cheater...did you run a source code analysis tool? |
hunterlxt
pushed a commit
to hunterlxt/rocksdb
that referenced
this pull request
Aug 27, 2021
* add option to disable write stall Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Nazgolze
pushed a commit
to Nazgolze/rocksdb-1
that referenced
this pull request
Sep 21, 2021
…ld-3.0.0 chore(package): update prebuild to version 3.0.0
Little-Wallace
pushed a commit
to Little-Wallace/rocksdb
that referenced
this pull request
Nov 11, 2021
* add option to disable write stall Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Little-Wallace
pushed a commit
to Little-Wallace/rocksdb
that referenced
this pull request
Dec 24, 2021
* add option to disable write stall Signed-off-by: Connor1996 <zbk602423539@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com> Co-authored-by: Connor <zbk602423539@gmail.com>
Little-Wallace
pushed a commit
to Little-Wallace/rocksdb
that referenced
this pull request
Dec 24, 2021
… version (facebook#258) * Revert "Add an option to disable write stall (facebook#251) (facebook#252)" This reverts commit 32b29a1. Signed-off-by: tabokie <xy.tao@outlook.com> * use ignore_unknown_options regardless of RocksDB version Signed-off-by: tabokie <xy.tao@outlook.com> * disable only for lower version and fix test Signed-off-by: tabokie <xy.tao@outlook.com>
BusyJay
pushed a commit
to BusyJay/rocksdb
that referenced
this pull request
Jul 25, 2022
* add option to disable write stall Signed-off-by: Connor1996 <zbk602423539@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
CompareCandidateFileincorrectly compares a file'spath_idagainst itself and will always return false.This is my first pull request against
rocksdband I have completed the CLA.