Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SstFileReader in Java API #5538

Closed
richardyc opened this issue Jul 4, 2019 · 2 comments
Closed

SstFileReader in Java API #5538

richardyc opened this issue Jul 4, 2019 · 2 comments
Labels

Comments

@richardyc
Copy link
Contributor

C++ currently has API for reading SST files with SstFileReader sst_file_reader.h. However, rocksdbjni does not have SstFileReader API. Having this over the current option DB::IngestExternalFile() could bring support for:

  • Ability to read sst files directly pulled from Snapshots. Current DB::IngestExternalFile() will raise

Exception in thread "main" org.rocksdb.RocksDBException: External file version not found

  • Ability to iterate through a sst file without the overhead of creating a new db
@miasantreble
Copy link
Contributor

Thanks @richardyc , will you be interested in contributing a PR for this?

@richardyc
Copy link
Contributor Author

richardyc commented Jul 9, 2019

I should be able to contribute a PR for this in the coming weeks. However, I don't have a lot of JNI developing experience so probably need to get familiar with it first.

facebook-github-bot pushed a commit that referenced this issue Sep 10, 2019
Summary:
Feature request as per #5538 issue.
Pull Request resolved: #5556

Differential Revision: D17219008

fbshipit-source-id: e31f18dec318416eac9dea8213bab31da96e1f3a
merryChris pushed a commit to merryChris/rocksdb that referenced this issue Nov 18, 2019
Summary:
Feature request as per facebook#5538 issue.
Pull Request resolved: facebook#5556

Differential Revision: D17219008

fbshipit-source-id: e31f18dec318416eac9dea8213bab31da96e1f3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants