Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SstFileReaderJNI] Added support for SstFileReader JNI interface #5556

Closed
wants to merge 8 commits into from
Closed

[SstFileReaderJNI] Added support for SstFileReader JNI interface #5556

wants to merge 8 commits into from

Conversation

richardyc
Copy link
Contributor

@richardyc richardyc commented Jul 10, 2019 •
edited
Loading

Feature request as per #5538 issue.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

adamretter
adamretter requested changes Jul 12, 2019
View reviewed changes
Copy link
Collaborator

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, otherwise it looks good.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

adamretter
adamretter approved these changes Aug 3, 2019
View reviewed changes
Copy link
Collaborator

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you :-)

@adamretter
Copy link
Collaborator

@siying Can this one be merged please?

@richardyc
Copy link
Contributor Author

@siying any updates on the merge? We might need this functionality pretty soon. Thanks!

facebook-github-bot
facebook-github-bot reviewed Sep 6, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siying is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@siying siying self-assigned this Sep 10, 2019
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 699e1b5.

merryChris pushed a commit to merryChris/rocksdb that referenced this pull request Nov 18, 2019
@richardyc @facebook-github-bot
Added support for SstFileReader JNI interface (facebook#5556)
5426970 
Summary:
Feature request as per facebook#5538 issue.
Pull Request resolved: facebook#5556

Differential Revision: D17219008

fbshipit-source-id: e31f18dec318416eac9dea8213bab31da96e1f3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@adamretter adamretter adamretter approved these changes

Assignees

@siying siying

Labels
CLA Signed java-api Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@richardyc @facebook-github-bot @adamretter @siying