Introduce XPRESS compresssion on Windows. #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CompressionType::kSnappyCompression, | ||
| CompressionType::kZlibCompression, | ||
| CompressionType::kBZip2Compression, | ||
| CompressionType::kLZ4Compression, // Skip the H type |
There was a problem hiding this comment.
I don't think we should skip LZ4HC. It is a good compaction style.
yuslepukhin
force-pushed
the
xpress_compression
branch
from
34d8ec3
to
a0879d5
Compare
Comparable with Snappy on comp ratio. Implemented using Windows API, does not require external package. Avaiable since Windows 8 and server 2012. Use -DXPRESS=1 with CMake to enable.
yuslepukhin
force-pushed
the
xpress_compression
branch
from
a0879d5
to
129d89a
Compare
|
Travis failures are Java related and unrelated to my change |
|
@siying Pls, take a look when you have a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparable with Snappy on comp ratio.
Implemented using Windows API, does not require external package.
Avaiable since Windows 8 and server 2012.
Use -DXPRESS=1 with CMake to enable.