Exporting compaction stats in the form of a map #1477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently the compaction stats are printed to stdout. We want to export the compaction stats in a map format so that the upper layer apps (e.g., MySQL) could present the stats in any format required by the them. Test Plan: An exiting unit test is augmented to also test the new export API: "./db_test2 --gtest_filter=*AutomaticCompactionOverlapManualCompaction"
|
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@maysamyabandeh updated the pull request - view changes - changes since last import |
|
@maysamyabandeh updated the pull request - view changes - changes since last import |
| ? 0.0 | ||
| : static_cast<double>(comp_stats_[level].bytes_written) / | ||
| comp_stats_[level].bytes_read_non_output_levels; | ||
| auto level_stats = std::map<LevelStatType, double>(); |
There was a problem hiding this comment.
Let's rewrite it this way
std::map<LevelStatType, double>() level_stats;
| double w_amp = compaction_stats_sum->bytes_written / | ||
| static_cast<double>(curr_ingest + 1); | ||
| // Stats summary across levels | ||
| auto level_stats = std::map<LevelStatType, double>(); |
There was a problem hiding this comment.
Also what do you think about renaming this to sum_stats since it's not actually a level stats
| /** | ||
| * Dump Compaction Level stats to a map of stat name to value in double. | ||
| * The level in stat name is represented with a prefix "Lx" where "x" | ||
| * is the level number. A special level "Sum" represnts the sum of a stat |
There was a problem hiding this comment.
nit:
represnts => represents
fir => for
|
@maysamyabandeh updated the pull request - view changes - changes since last import |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently the compaction stats are printed to stdout. We want to export the compaction stats in a map format so that the upper layer apps (e.g., MySQL) could present
the stats in any format required by the them.
Test Plan: An exiting unit test is augmented to also test the new export API: "./db_test2 --gtest_filter=*AutomaticCompactionOverlapManualCompaction"