Kill flashcache code in RocksDB #1588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
siying
approved these changes
Nov 29, 2016
|
@igorcanadi I checkout it out and built locally, so it's good to go. Can you resolve the conflicts? |
Summary: Now that we have userspace persisted cache, we don't need flashcache anymore. Test Plan: I ran 'make check' and it failed, but I don't know why. I'm assuming flaky tests since this is only removing code and the compile passed. Reviewers: sdong Differential Revision: https://phabricator.intern.facebook.com/D4244842
igorcanadi
force-pushed
the
flashcachebyebye
branch
from
43dfff0
to
ff629f0
Compare
|
@igorcanadi updated the pull request - view changes - changes since last import |
siying
pushed a commit
that referenced
this pull request
Dec 1, 2016
Summary: Now that we have userspace persisted cache, we don't need flashcache anymore. Closes #1588 Differential Revision: D4245114 Pulled By: igorcanadi fbshipit-source-id: e2c1c72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Now that we have userspace persisted cache, we don't need flashcache anymore.
Test Plan: I ran 'make check' and it failed, but I don't know why. I'm assuming flaky tests since this is only removing code and the compile passed.
Reviewers: sdong
Differential Revision: https://phabricator.intern.facebook.com/D4244842