Fix rocksdb::Status::getState #1714
Conversation
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@adamretter Some of the tests a failing in travis. Do you mind take a look? |
adamretter
force-pushed
the
fix-status-getState
branch
from
9778b77
to
ae6064e
Compare
|
@adamretter updated the pull request - view changes - changes since last import |
adamretter
force-pushed
the
fix-status-getState
branch
from
ae6064e
to
1bd1655
Compare
|
@adamretter updated the pull request - view changes - changes since last import |
adamretter
force-pushed
the
fix-status-getState
branch
from
1bd1655
to
59ab411
Compare
|
@adamretter updated the pull request - view changes - changes since last import |
|
@adamretter updated the pull request - view changes - changes since last import |
adamretter
force-pushed
the
fix-status-getState
branch
from
f596738
to
5d7bef1
Compare
|
@adamretter updated the pull request - view changes - changes since last import |
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Is it safe to change the existing behavior where Status::GetStatus() returns "size + msg + sub_msg"? cc @siying @IslamAbdelRahman |
|
@yiwu-arbug I did not see it being used within the Rocks project anywhere apart from the one place I fixed it ;-) |
|
@adamretter Okay. Mind running |
This simplifies the implementation and doesn't use a custom encoding scheme for the bytes
adamretter
force-pushed
the
fix-status-getState
branch
from
5d7bef1
to
01af141
Compare
|
@adamretter updated the pull request - view changes - changes since last import |
|
@adamretter updated the pull request - view changes - changes since last import |
|
@yiwu-arbug I made the formatting changes. I am not certain if there is still a problem with the build or not, I can't seem to reproduce (macOS Sierra) but I think Travis had an issue still... any ideas? |
|
The tailing iterator test is broken for a while. I'm merging the change. |
|
@yiwu-arbug has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This fixes the Java API for Status#getState use in Native code and also simplifies the implementation of rocksdb::Status::getState.
Closes #1688