Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ThreadLocal implementation into .cc #1829

Closed
wants to merge 1 commit into from

Conversation

yuslepukhin
Copy link
Contributor

No description provided.

@yuslepukhin
Copy link
Contributor Author

Failures does not seem to be related to this PR

@facebook-github-bot
Copy link
Contributor

@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@siying
Copy link
Contributor

siying commented Feb 2, 2017

Looks good to me. I'm curious what's the reason for doing that? Did some code analyze tool complained?

@yuslepukhin
Copy link
Contributor Author

@siying The reason for this a memory isolation project that I am doing. For some global pieces it is easier to subst a .cc file and not touch the header until I come up with a better way of doing this. This and another PR are the last in the series. No more expected.
In this project I have to allocate different instances of databases in different pools and thus thread-local storage suddenly acquires one more dimension. I need to track the actual memory pool where the thread-local was allocated from. Same thing for global threadpools. Each task submitted must execute within the memory pool context of the instance it submitted it.

@yuslepukhin yuslepukhin deleted the thread_local_impl branch February 2, 2017 22:40
VitaliyLi pushed a commit to VitaliyLi/rocksdb that referenced this pull request Feb 3, 2017
Summary: Closes facebook#1829

Differential Revision: D4502314

Pulled By: siying

fbshipit-source-id: f46fac1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants