Fix clang compile error - [-Werror,-Wunused-lambda-capture] #1972
Conversation
Errors where:
db/version_set.cc:1535:20: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
[this](const Fsize& f1, const Fsize& f2) -> bool {
^
db/version_set.cc:1541:20: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
[this](const Fsize& f1, const Fsize& f2) -> bool {
^
db/db_test.cc:2983:27: error: lambda capture 'kNumPutsBeforeWaitForFlush' is not required to be captured for this use [-Werror,-Wunused-lambda-capture]
auto gen_l0_kb = [this, kNumPutsBeforeWaitForFlush](int size) {
^
clang version 5.0.0 (llvm-clang.git 79a6eca386d468058b31e2d4f54b1b736a12f558)
(llvm.git 31f450353208e4d108fff264a2eba433758a0709)
Signed-off-by: Daniel Black <daniel.black@au.ibm.com>
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Thank you for your contribution! |
|
thanks for reviewing/merging. Have a nice day. |
|
@grooverdan sorry I didn't realized that it broke the Windows build: https://ci.appveyor.com/project/Facebook/rocksdb/build/1.0.3679 c:\projects\rocksdb\db\db_test.cc(2993): error C3493: 'kNumPutsBeforeWaitForFlush' cannot be implicitly captured because no default capture mode has been specified [C:\projects\rocksdb\build\db_test.vcxproj] This warning is directly contradicting with what you have fixed. Can you figure out what's going on? |
|
@grooverdan Maybe I can move kNumPutsBeforeWaitForFlush into the lambda function to resolve the problem. Let me give it a try. |
|
Looks like a good fix. Apologies for not checking the Windows CI either. I guess we'll see soon if Windows is happy with that. |
Errors where:
db/version_set.cc:1535:20: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
[this](const Fsize& f1, const Fsize& f2) -> bool {
^
db/version_set.cc:1541:20: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
[this](const Fsize& f1, const Fsize& f2) -> bool {
^
db/db_test.cc:2983:27: error: lambda capture 'kNumPutsBeforeWaitForFlush' is not required to be captured for this use [-Werror,-Wunused-lambda-capture]
auto gen_l0_kb = [this, kNumPutsBeforeWaitForFlush](int size) {
^