Move various string utility functions into string_util #2094
Conversation
|
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@sagar0 updated the pull request - view changes - changes since last import |
|
Looks great! let's wait for the tests and then land. |
|
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Yup, I will wait for the tests; I am already closely monitoring them. I just updated the PR with minor fixes for java and lite versions.
That's fine. I'll rebase. |
|
Sorry I landed #2090 so you need to resolve more conflicts now. |
Summary: This is part of an effort to club all string related utility functions into a common place, in string_util. logging.h should contain only contain functions related to logging.
This is part of an effort to club all string related utility functions into a common place, in string_util. options_helper.[h,cc] has many string utility functions that could be useful in other places, and need to be in a more common place like string_util. Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Blame Revision:
Exceptions are not enabled in RocksDB Lite. So ifdef out functions that could throw exceptions.
sagar0
force-pushed
the
gather-string-utils
branch
from
9805dfc
to
96512f7
Compare
|
@sagar0 updated the pull request - view changes - changes since last import |
|
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: This is an effort to club all string related utility functions into one common place, in string_util, so that it is easier for everyone to know what string processing functions are available. Right now they seem to be spread out across multiple modules, like logging and options_helper. Check the sub-commits for easier reviewing. Closes facebook#2094 Differential Revision: D4837730 Pulled By: sagar0 fbshipit-source-id: 344278a
This is an effort to club all string related utility functions into one common place, in string_util, so that it is easier for everyone to know what string processing functions are available. Right now they seem to be spread out across multiple modules, like logging and options_helper.
Test plan: