Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some files under util/ to separate dirs #2090

Closed
wants to merge 4 commits into from

Conversation

siying
Copy link
Contributor

@siying siying commented Apr 5, 2017

Summary: Move some files under util/ to new directories env/, monitoring/ options/ and cache/

Test Plan: Run all existing tests.

@facebook-github-bot
Copy link
Contributor

@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@siying updated the pull request - view changes - changes since last import

@facebook-github-bot
Copy link
Contributor

@siying updated the pull request - view changes - changes since last import

@siying siying changed the title Move some files under util/ to separtes dirs Move some files under util/ to separate dirs Apr 5, 2017
@IslamAbdelRahman
Copy link
Contributor

Is unity failure related ?

@siying
Copy link
Contributor Author

siying commented Apr 6, 2017

@IslamAbdelRahman I don't know but I fixed it. Forgot to relaunch Phabricator tests.

@IslamAbdelRahman
Copy link
Contributor

Cool, can you also run

python ./buckifier/buckify_rocksdb.py

To update the targets file

@facebook-github-bot
Copy link
Contributor

@siying updated the pull request - view changes - changes since last import

@facebook-github-bot
Copy link
Contributor

@siying updated the pull request - view changes - changes since last import

@facebook-github-bot
Copy link
Contributor

@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Move some files under util/ to new directories env/, monitoring/ options/ and cache/

Test Plan: Run all existing tests.
Summary: Move some files under util/ to new directories env/, monitoring/ options/ and cache/

Test Plan: Run all existing tests.
@facebook-github-bot
Copy link
Contributor

@siying updated the pull request - view changes - changes since last import

@facebook-github-bot
Copy link
Contributor

@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@siying updated the pull request - view changes - changes since last import

@facebook-github-bot
Copy link
Contributor

@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mikhail-antonov pushed a commit to mikhail-antonov/rocksdb that referenced this pull request Apr 12, 2017
Summary:
Move some files under util/ to new directories env/, monitoring/ options/ and cache/
Closes facebook#2090

Differential Revision: D4833681

Pulled By: siying

fbshipit-source-id: 2fd8bef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants