Revert how check_format_compatible.sh checkout release branches. #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In a previous commit, I changed the way to checkout release branches from "git checkout <branch_name>" to "git checkout origin/<branch_name>". However, this doesn't seem to work in our CI environment. Revert it.
sagar0
approved these changes
Apr 20, 2017
sagar0
reviewed
Apr 20, 2017
| @@ -76,7 +76,7 @@ https_proxy="fwdproxy:8080" git fetch github_origin | |||
| for checkout_obj in "${checkout_objs[@]}" | |||
| do | |||
| echo == Generating DB from "$checkout_obj" ... | |||
| git checkout origin/$checkout_obj | |||
There was a problem hiding this comment.
My bad, too. I saw the 'origin' in the earlier PR, and spent a few seconds thinking if it should instead be parameterized instead of hardcoding to origin. But that thought never made it from my head to be a real comment on the PR :) .
There was a problem hiding this comment.
The reason I added it was that in my local checkout, without origin it doesn't work anymore. A new repo clone works though. I thought adding a origin would just solve the problem. Looks like it doesn't.
|
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In a previous commit, I changed the way to checkout release branches from "git checkout <branch_name>" to "git checkout origin/<branch_name>". However, this doesn't seem to work in our CI environment. Revert it.