Fix a wrong log formatting #3345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I experienced weird segfault because of this mismatch of type in log formatting. Fix it. Test Plan: Run db_bench and see log outputs in log files.
siying
requested review from
sagar0,
maysamyabandeh,
yiwu-arbug and
miasantreble
sagar0
approved these changes
Jan 9, 2018
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
The appveyor build break doesn't seem to be related. |
There was a problem hiding this comment.
@siying is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
siying
added a commit
that referenced
this pull request
Jan 11, 2018
Summary: I experienced weird segfault because of this mismatch of type in log formatting. Fix it. Closes #3345 Differential Revision: D6687224 Pulled By: siying fbshipit-source-id: c51fb1c008b7ebc3efdc353a4adad3e8f5b3e9de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I experienced weird segfault because of this mismatch of type in log formatting. Fix it.
Test Plan: Run db_bench and see log outputs in log files.