Fix some typos in comments and docs. #3568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
anand1976
approved these changes
Mar 6, 2018
siying
reviewed
Mar 8, 2018
| @@ -214,7 +214,7 @@ struct BlockBasedTableOptions { | |||
| // encode compressed blocks with LZ4, BZip2 and Zlib compression. If you | |||
| // don't plan to run RocksDB before version 3.10, you should probably use | |||
| // this. | |||
| // This option only affects newly written tables. When reading exising tables, | |||
| // This option only affects newly written tables. When reading existing tables, | |||
There was a problem hiding this comment.
Our internal CI warned that this line exceeds 80 characters.
| @@ -319,7 +319,7 @@ struct PlainTableOptions { | |||
| }; | |||
|
|
|||
| // -- Plain Table with prefix-only seek | |||
| // For this factory, you need to set Options.prefix_extrator properly to make it | |||
| // For this factory, you need to set Options.prefix_extractor properly to make it | |||
There was a problem hiding this comment.
Another warning about this line exceeds 80-char.
| @@ -67,7 +67,7 @@ class SstFileWriter { | |||
| // be ingested into this column_family, note that passing nullptr means that | |||
| // the column_family is unknown. | |||
| // If invalidate_page_cache is set to true, SstFileWriter will give the OS a | |||
| // hint that this file pages is not needed everytime we write 1MB to the file. | |||
| // hint that this file pages is not needed every time we write 1MB to the file. | |||
There was a problem hiding this comment.
@siying is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.