Create lgtm.yml for LGTM.com C/C++ analysis #4058
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
(see PR facebook#4058 for details)
After discussing RocksDB on https://discuss.lgtm.com/t/c-c-lang-missing-for-facebook-rocksdb/1079
|
I've just signed the CLA. Hopefully the bot will notice that soon 🙂 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
we can add it back to README.md if we find the suggestions useful and it becomes part of our workflow
There was a problem hiding this comment.
@ajkr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: As discussed with thatsafunnyname [here](https://discuss.lgtm.com/t/c-c-lang-missing-for-facebook-rocksdb/1079): this configuration enables C/C++ analysis for RocksDB on LGTM.com. The initial commit will contain a build command (simple `make`) that previously resulted in a build error. The build log will then be available on LGTM.com for you to investigate (if you like). I'll immediately add a second commit to this PR to correct the build command to `make static_lib`, which worked when I tested it earlier today. If you like you can also enable automatic code review in pull requests. This will alert you to any new code issues before they actually get merged into `master`. Here's an example of how that works for the AMPHTML project: ampproject/amphtml#13060. You can enable it yourself here: https://lgtm.com/projects/g/facebook/rocksdb/ci/. I'll also add a badge to your README.md in a separate commit — feel free to remove that from this PR if you don't like it. (Full disclosure: I'm part of the LGTM.com team 🙂. Ping samlanning) Closes facebook#4058 Differential Revision: D8648410 Pulled By: ajkr fbshipit-source-id: 98d55fc19cff1b07268ac8425b63e764806065aa
As discussed with @thatsafunnyname here: this configuration enables C/C++ analysis for RocksDB on LGTM.com.
The initial commit will contain a build command (simple
make) that previously resulted in a build error. The build log will then be available on LGTM.com for you to investigate (if you like). I'll immediately add a second commit to this PR to correct the build command tomake static_lib, which worked when I tested it earlier today.If you like you can also enable automatic code review in pull requests. This will alert you to any new code issues before they actually get merged into
master. Here's an example of how that works for the AMPHTML project: ampproject/amphtml#13060. You can enable it yourself here: https://lgtm.com/projects/g/facebook/rocksdb/ci/.I'll also add a badge to your README.md in a separate commit — feel free to remove that from this PR if you don't like it.
(Full disclosure: I'm part of the LGTM.com team 🙂. Ping @samlanning)