#3865 followup for fix performance degression introduced by switching order of merge operands #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…witching order of operands between calls of MergeContext.PushOperand and MergeOperator.ShouldMerge(MergeContext.GetOperands()): one more place in get_context.cc
There was a problem hiding this comment.
sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
sagar0
changed the title
sagar0
approved these changes
Aug 17, 2018
riversand963
pushed a commit
to riversand963/rocksdb
that referenced
this pull request
Aug 21, 2018
…witching order of operands (facebook#4284) Summary: Followup for facebook#4266. There is one more place in **get_context.cc** where **MergeOperator::ShouldMerge** should be called with reversed list of operands. Pull Request resolved: facebook#4284 Differential Revision: D9380008 Pulled By: sagar0 fbshipit-source-id: 70ec26e607e5b88465e1acbdcd6c6171bd76b9f2
riversand963
pushed a commit
to riversand963/rocksdb
that referenced
this pull request
Aug 22, 2018
…witching order of operands (facebook#4284) Summary: Followup for facebook#4266. There is one more place in **get_context.cc** where **MergeOperator::ShouldMerge** should be called with reversed list of operands. Pull Request resolved: facebook#4284 Differential Revision: D9380008 Pulled By: sagar0 fbshipit-source-id: 70ec26e607e5b88465e1acbdcd6c6171bd76b9f2
rcane
pushed a commit
to rcane/rocksdb
that referenced
this pull request
Sep 13, 2018
…witching order of operands (facebook#4284) Summary: Followup for facebook#4266. There is one more place in **get_context.cc** where **MergeOperator::ShouldMerge** should be called with reversed list of operands. Pull Request resolved: facebook#4284 Differential Revision: D9380008 Pulled By: sagar0 fbshipit-source-id: 70ec26e607e5b88465e1acbdcd6c6171bd76b9f2
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #4266. There is one more place in get_context.cc where MergeOperator::ShouldMerge should be called with reversed list of operands.