Move FIFOCompactionPicker to a separate file #4724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar0
changed the title
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
sagar0
commented
Nov 28, 2018
riversand963
approved these changes
Nov 29, 2018
There was a problem hiding this comment.
LGTM. Thanks to @sagar0 for re-organizing the code.
I left a minor comment.
|
@sagar0 has updated the pull request. Re-import the pull request |
|
@sagar0 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@riversand963 can you take another look? I updated based on your suggestion. |
yiwu-arbug
pushed a commit
to tikv/rocksdb
that referenced
this pull request
Jan 16, 2020
Summary: **Summary:** Simplified the code layout by moving FIFOCompactionPicker to a separate file. **Why?:** While trying to add ttl functionality to universal compaction, I found that `FIFOCompactionPicker` class and its impl methods to be interspersed between `LevelCompactionPicker` methods which kind-of made the code a little hard to traverse. So I moved `FIFOCompactionPicker` to a separate compaction_picker_fifo.h/cc file, similar to `UniversalCompactionPicker`. Pull Request resolved: facebook#4724 Differential Revision: D13227914 Pulled By: sagar0 fbshipit-source-id: 89471766ea67fa4d87664a41c057dd7df4b3d4e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Simplified the code layout by moving FIFOCompactionPicker to a separate file.
Why?:
While trying to add ttl functionality to universal compaction, I found that
FIFOCompactionPickerclass and its impl methods to be interspersed betweenLevelCompactionPickermethods which kind-of made the code a little hard to traverse. So I movedFIFOCompactionPickerto a separate compaction_picker_fifo.h/cc file, similar toUniversalCompactionPicker.Test Plan:
make check