Disable new Bloom filter assertion #6128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: A longstanding bug in our C interface can trigger this assertion; see issue facebook#6129. Disabling the assertion for now (for 6.6.0) and will re-enable on fix of that bug.
pdillinger
force-pushed
the
disable-filter-assertion
branch
from
e5d9988
to
ef1ac4a
Compare
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
riversand963
reviewed
Dec 6, 2019
riversand963
approved these changes
Dec 6, 2019
siying
approved these changes
Dec 6, 2019
pdillinger
added a commit
that referenced
this pull request
Dec 6, 2019
Summary: A longstanding bug in our C interface can trigger this assertion; see issue #6129. Disabling the assertion for now (for 6.6.0) and will re-enable on fix of that bug. Pull Request resolved: #6128 Differential Revision: D18854899 Pulled By: pdillinger fbshipit-source-id: 9eb5294b9f11b208dc1a8cc148aaa31e47ff892b
|
@pdillinger merged this pull request in 6db57bc. |
wolfkdy
pushed a commit
to wolfkdy/rocksdb
that referenced
this pull request
Dec 22, 2019
Summary: A longstanding bug in our C interface can trigger this assertion; see issue facebook#6129. Disabling the assertion for now (for 6.6.0) and will re-enable on fix of that bug. Pull Request resolved: facebook#6128 Differential Revision: D18854899 Pulled By: pdillinger fbshipit-source-id: 9eb5294b9f11b208dc1a8cc148aaa31e47ff892b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: A longstanding bug in our C interface can trigger this
assertion; see issue #6129. Disabling the assertion for now
(for 6.6.0) and will re-enable on fix of that bug.