Add unit test for TransactionLockMgr #6599
Conversation
ghost
requested a review
from 
There was a problem hiding this comment.
@Cheng-Chang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@cheng-chang has updated the pull request. Re-import the pull request |
|
@cheng-chang has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@Cheng-Chang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| auto txn = NewTxn(); | ||
| ASSERT_OK(locker_->TryLock(txn, 1, "k", env_, true)); | ||
| ASSERT_OK(locker_->TryLock(txn, 1, "k", env_, false)); | ||
| delete txn; |
There was a problem hiding this comment.
I don't think lock downgrade is actually supported, so would be nice to verify that lock is still exclusively locked.
Might be good to do this for some of the other test cases too.
| port::Thread BlockUntilWaitingTxn(std::function<void()> f) { | ||
| std::atomic<bool> reached(false); | ||
| ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( | ||
| "TransactionLockMgr::AcquireWithTimeout:WaitingTxn", | ||
| [&](void* /*arg*/) { reached.store(true); }); | ||
| ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); | ||
|
|
||
| port::Thread t(f); | ||
|
|
||
| while (!reached.load()) { | ||
| std::this_thread::sleep_for(std::chrono::milliseconds(100)); | ||
| } | ||
| ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); | ||
| ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); | ||
|
|
||
| return t; | ||
| } |
There was a problem hiding this comment.
I feel like this section should come after the "SharedLocks" test.
|
@Cheng-Chang merged this pull request in d648a0e. |
Although there are tests related to locking in transaction_test, this new test directly tests against TransactionLockMgr.
Test Plan:
make transaction_lock_mgr_test && ./transaction_lock_mgr_test