Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ldb load column family options from OPTIONS file #7847

Closed
wants to merge 2 commits into from
Closed

Make ldb load column family options from OPTIONS file #7847

wants to merge 2 commits into from

Commits on Jan 11, 2021

  1. Make ldb load column family options from OPTIONS file 

    Summary:
When the --try_load_options is used in conjunction with the
--column_family option, ldb incorrectly sets the ColumnFamilyOptions for
that column family to defaults. This PR fixes that by retaining from the
OPTIONS file and applying command line overrides.

Test Plan:
Add a unit test in ldb_cmd_test
    anand76 committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    5562b80 View commit details
    Browse the repository at this point in the history

  2. Address review comments

    anand76 committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    a44fa30 View commit details
    Browse the repository at this point in the history