Update clang-format-diff.py path #7944
Conversation
Summary: Recent Github actions of format checking fail due to invalid location from where clang-format-diff.py is downloaded. Update the path to point to a stable, archived location. Test Plan: manually check the result of Github action.
|
cc @mrambacher |
.github/workflows/sanity_check.yml
Outdated
| @@ -32,7 +32,7 @@ jobs: | |||
| - name: Download clang-format-diff.py | |||
| uses: wei/wget@v1 | |||
| with: | |||
| args: https://raw.githubusercontent.com/llvm/llvm-project/master/clang/tools/clang-format/clang-format-diff.py | |||
| args: https://raw.githubusercontent.com/llvm-mirror/clang/master/tools/clang-format/clang-format-diff.py | |||
There was a problem hiding this comment.
Thanks @riversand963 ! Was about to put out a PR when I noticed yours :) I believe we could stick with the official repo (i.e. no need to move to the unofficial mirror) as the script is still there under https://raw.githubusercontent.com/llvm/llvm-project/main/clang/tools/clang-format/clang-format-diff.py
There was a problem hiding this comment.
The only thing that's different is the branch name.
There was a problem hiding this comment.
Sure, let me update.
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks @ltamasi for the review! |
|
@riversand963 merged this pull request in 48669be. |
Summary: Recent Github actions of format checking fail due to invalid location from where clang-format-diff.py is downloaded. Update the path to point to a stable, archived location. Pull Request resolved: facebook#7944 Test Plan: manually check the result of Github action. Reviewed By: ltamasi Differential Revision: D26345066 Pulled By: riversand963 fbshipit-source-id: 2b1a58c2e59c2f1eb11202d321d2ea002cb0917e
Summary:
Recent Github actions of format checking fail due to invalid location
from where clang-format-diff.py is downloaded. Update the path to point
to a stable, archived location.
Test Plan: manually check the result of Github action.