New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert unlimited max_open_files for FIFO compaction. #8172

Closed

thejchap wants to merge 1 commit into facebook:master from thejchap:bug/fifo-compaction-with-ttl-and-max-open-files-1

Commits on Apr 14, 2021

Assert valid option combination for FIFO compaction.

Resolves facebook#8014
- Add an assertion on `DB::Open` to ensure `db_options.max_open_files` is unlimited if FIFO Compaction is being used.
- This is to align with what the docs mention and to prevent premature data deletion.
- Update tests to work with this assertion.

Test Plan:
'make check -j$(nproc)`

Justin Chapman committed Apr 14, 2021