Rename variables in ImmutableCFOptions to avoid conflicts with ImmutableDBOptions #8227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed (almost all) the values in the Immutable option formats to match the Options form, meaning that more are shared_ptr. This change will allow an Option to be re-created from its Immutable and Mutable forms. This is stage 1 of this process. A goal is to introduce a ImmutableOptions class that contains the Immutable DB and CF Options to eliminate cross referencing between the two (there are options in ImmutableCFOptions that are ImmutableDBOptions. Because of the linkage, promoting options to Mutable can be difficult).
To test performance delta.
Renamed the variables in ImmutableCFOptions (info_log, statistics) to (logger, stats). This is step 2 of creating an ImmutableOptions struct that is both an ImmutableDBOptions and ImmutableCFOptions. The name change is necessary because the ImmutableDBOptions has members with those same names that are a different type. There is no functionality change associated with this PR. Only variable renaming.
|
@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jay-zhuang
approved these changes
Apr 26, 2021
|
@mrambacher has updated the pull request. You must reimport the pull request before landing. |
|
@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@mrambacher merged this pull request in 0ca6d62. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming ImmutableCFOptions::info_log and statistics to logger and stats. This is stage 2 in creating an ImmutableOptions class. It is necessary because the names match those in ImmutableOptions and have different types.