-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not truncate WAL if in read_only mode #8313
Closed
Closed
Commits on May 18, 2021
-
Do not truncate WAL if in read_only mode
Noticed ```openat``` system call with ```O_WRONLY``` flag and ```sync_file_range``` and ```truncate``` on WAL file when using ```rocksdb::DB::OpenForReadOnly``` by way of ```db_bench --readonly=true --benchmarks=readseq --use_existing_db=1 --num=1 ...``` I think introduced by facebook@7d7f144
Configuration menu - View commit details
-
Copy full SHA for 32cfdfa - Browse repository at this point
Copy the full SHA 32cfdfaView commit details
Commits on May 21, 2021
-
Test mtime of files after ReadOnlyReopen
This catches the WAL file being truncated and the modification time on it changing. I am not sure if a mock filesystem with mock clock could be used to avoid having to sleep 1.1s. The test could also check the set of files is the same and that the sizes are also unchanged. Before: [ RUN ] DBBasicTest.ReadOnlyReopenMtimeUnchanged db/db_basic_test.cc:182: Failure Expected equality of these values: file_mtime_after_readonly_reopen Which is: 1621611136 file_mtime_before_readonly_reopen Which is: 1621611135 file is: 000010.log [ FAILED ] DBBasicTest.ReadOnlyReopenMtimeUnchanged (1108 ms) After: [ RUN ] DBBasicTest.ReadOnlyReopenMtimeUnchanged [ OK ] DBBasicTest.ReadOnlyReopenMtimeUnchanged (1108 ms)
Configuration menu - View commit details
-
Copy full SHA for f493b75 - Browse repository at this point
Copy the full SHA f493b75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8980c3a - Browse repository at this point
Copy the full SHA 8980c3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e089397 - Browse repository at this point
Copy the full SHA e089397View commit details -
Configuration menu - View commit details
-
Copy full SHA for b75cd8f - Browse repository at this point
Copy the full SHA b75cd8fView commit details
Commits on May 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cec1ad5 - Browse repository at this point
Copy the full SHA cec1ad5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96f972b - Browse repository at this point
Copy the full SHA 96f972bView commit details
Commits on May 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 25234ae - Browse repository at this point
Copy the full SHA 25234aeView commit details
Commits on May 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 625f9b8 - Browse repository at this point
Copy the full SHA 625f9b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9b15c1 - Browse repository at this point
Copy the full SHA d9b15c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f17fb19 - Browse repository at this point
Copy the full SHA f17fb19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8679316 - Browse repository at this point
Copy the full SHA 8679316View commit details
Commits on May 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 60d38f6 - Browse repository at this point
Copy the full SHA 60d38f6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.