Log the amount of blob garbage generated by compactions in the MANIFEST #8450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h KV during compaction if set
…ces blob files, chain iterators correctly
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jay-zhuang
approved these changes
Jun 24, 2021
| @@ -1136,6 +1147,15 @@ void CompactionJob::ProcessKeyValueCompaction(SubcompactionState* sub_compact) { | |||
| input = clip.get(); | |||
| } | |||
|
|
|||
| std::unique_ptr<InternalIterator> blob_counter; | |||
|
|
|||
| if (sub_compact->compaction->DoesInputReferenceBlobFiles()) { | |||
There was a problem hiding this comment.
cool that we check it first to avoid unnecessary counting.👍
This was referenced Jun 25, 2021
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this pull request
Jul 6, 2021
…nge" Summary: We ended up using a different approach for tracking the amount of garbage in blob files (see e.g. facebook#8450), so the ability to apply only a range of table property collectors is now unnecessary. The patch reverts this part of facebook#8298 while keeping the cleanup. Test Plan: `make check`
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 6, 2021
…ange (#8465) Summary: We ended up using a different approach for tracking the amount of garbage in blob files (see e.g. #8450), so the ability to apply only a range of table property collectors is now unnecessary. The patch reverts this part of #8298 while keeping the cleanup done in that PR. Pull Request resolved: #8465 Test Plan: `make check` Reviewed By: jay-zhuang Differential Revision: D29399921 Pulled By: ltamasi fbshipit-source-id: af64816c357d0829b9d7ba8ca1477038138f6f0a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The patch builds on
BlobGarbageMeterandBlobCountingIterator(introduced in #8426 and
#8443 respectively)
and ties it all together. It measures the amount of garbage
generated by a compaction and logs the corresponding
BlobFileGarbagerecords as part of the compaction job's
VersionEdit. Note: in orderto have accurate results,
kRemoveAndSkipUntilfor compaction filtersis implemented using iteration.
Test Plan:
Ran
make checkand the crash test script.