Partially revert the "apply subrange of table property collectors" change #8465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ltamasi
changed the title
…nge" Summary: We ended up using a different approach for tracking the amount of garbage in blob files (see e.g. facebook#8450), so the ability to apply only a range of table property collectors is now unnecessary. The patch reverts this part of facebook#8298 while keeping the cleanup. Test Plan: `make check`
ltamasi
force-pushed
the
revert_prop_collector_range_part
branch
from
df5f2dd
to
0ba1143
Compare
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We ended up using a different approach for tracking the amount of
garbage in blob files (see e.g. #8450),
so the ability to apply only a range of table property collectors is
now unnecessary. The patch reverts this part of
#8298 while keeping the cleanup done
in that PR.
Test Plan:
make check