[TechDebt] Minor improvement to #8428 (Account for dictionary-building buffer in global memory limit) #9032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hx235
changed the title
hx235
force-pushed
the
minor_improve_compress_dic_mem_account
branch
from
1838f5c
to
cb75b21
Compare
hx235
changed the title
hx235
force-pushed
the
minor_improve_compress_dic_mem_account
branch
from
cb75b21
to
46d961b
Compare
|
@hx235 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
hx235
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Context:
cache_rev_mngtocompression_dict_buffer_cache_res_mgrcache_res_mgrinBlockBasedTableBuilderand to use correct short-hand for the words "reservation", "manager"table_options.block_cache == nullptrin additional totable_options.no_block_cache == trueto be conditions where we don't create aCacheReservationManagertable_options.no_block_cache == trueis equivalent totable_options.block_cache == nullptrby API. But since segment fault will be generated by passingnullptrintoCacheReservationManager's constructor, it does not hurt to directly verifytable_options.block_cache != nullptrbefore passing inis_cache_fulltoexceeds_global_block_cache_limitTest: