[TechDebt][ResourceMngmt]Minor improvement to CacheReservationManager/WriteBufferManager/CompressionDictBuilding #9139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hx235 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Update:
|
Thanks for reviewing!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Similar to #9072, #9032, this PR is to clear up some small tech debts in coding of my previous work.
Summary:
CacheReservationManagerTest, replaced hard-coded test value related toCacheReservationManager::kSizeDummyEntrywithCacheReservationManager::GetDummyEntrySize()CacheReservationManager::kSizeDummyEntrybeing256 * 1024. As we don't anticipate change in this value for the near future, we just live with it now.WriteBufferManager, renamed private variablecache_rev_mng/cache_rev_mng_mutocache_res_mgr/cache_res_mgr_mufor accurate abbreviation ofcache_reservation_managerBlockBasedTableBuilder, added a line of comment about releasing cache for releasing all the buffered data blocks used in compression dictionary buildingTesting: