Remove BlockBasedTableOptions.hash_index_allow_collision #9454
Conversation
|
@siying has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| // rocksdb_block_based_options_set_hash_index_allow_collision() | ||
| // is removed since BlockBasedTableOptions.hash_index_allow_collision() | ||
| // is removed |
There was a problem hiding this comment.
I didn't see such a notice in other removal PRs but am fine with having it. Although I didn't strongly feel it's needed so don't plan to push others to add such notice (if you do, you may wish to check all the other removal PRs that have been approved/landed lately).
There was a problem hiding this comment.
If the current public API is consistent with itself, there should be no reason to talk in API docs about what used to be. History is for HISTORY.md, git log, etc.
siying
force-pushed
the
remove_hash_index_allow_collision
branch
from
68f3b7d
to
aaf503f
Compare
|
@siying has updated the pull request. You must reimport the pull request before landing. |
|
@siying has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
siying
force-pushed
the
remove_hash_index_allow_collision
branch
from
aaf503f
to
03ecaad
Compare
|
@siying has updated the pull request. You must reimport the pull request before landing. |
|
@siying has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
siying
force-pushed
the
remove_hash_index_allow_collision
branch
from
03ecaad
to
b61e0f8
Compare
|
@siying has updated the pull request. You must reimport the pull request before landing. |
|
@siying has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: BlockBasedTableOptions.hash_index_allow_collision is already deprecated and has no effect. Delete it for preparing 7.0 release. Test Plan: Run all existing tests.
siying
force-pushed
the
remove_hash_index_allow_collision
branch
from
b61e0f8
to
7d99f9f
Compare
|
@siying has updated the pull request. You must reimport the pull request before landing. |
|
@siying has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
BlockBasedTableOptions.hash_index_allow_collision is already deprecated and has no effect. Delete it for preparing 7.0 release.
Test Plan: Run all existing tests.