Remove deprecated API AdvancedColumnFamilyOptions::soft_rate_limit #9451
Conversation
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
force-pushed
the
rocksdb7.0_dep_soft_rate_limit
branch
from
dc305df
to
6be2b44
Compare
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
changed the title
|
A small comment: be aware that PR title will become commit title after it is merged. Commit title is permanent. When later RocksDB developers blame the code or try to find history, they look at the commit title. So write your PR title and description so that any RocksDB developer could understand it after 3 years or 5 years. In my opinion, "[TechDebt]" is not very helpful there, as well as "[1/3]". |
Good call - fixing it! |
hx235
changed the title
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
HISTORY.md
Outdated
| @@ -4,6 +4,7 @@ | |||
| * Remove HDFS support from main repo. | |||
| * Remove librados support from main repo. | |||
| * Remove deprecated API DB::AddFile from main repo. | |||
| * Remove deprecated API AdvancedColumnFamilyOptions::soft_rate_limit | |||
There was a problem hiding this comment.
Thanks for being the first to drop "from main repo".
There was a problem hiding this comment.
(time to see who merge it first #9454
hx235
force-pushed
the
rocksdb7.0_dep_soft_rate_limit
branch
from
8ad8d99
to
76f011a
Compare
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
hx235
force-pushed
the
rocksdb7.0_dep_soft_rate_limit
branch
from
76f011a
to
adaf586
Compare
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
Update:
|
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Close this to combine with #9452 for less rebasing efforts |
Context/Summary:
AdvancedColumnFamilyOptions::soft_rate_limithas been marked as deprecated since 4.4.0 (2016-01-14) and it's time to actually remove the code.soft_rate_limitincf_mutable_options_type_infoto prevent throwingInvalidArgumentinGetColumnFamilyOptionsFromMapwhen reading an option file still withsoft_rate_limit(e.g, old option file generated from RocksDB before thissoft_rate_limitdeprecation)soft_rate_limitin underOptionsOldApiTestto test the case mentioned above.Test:
Rely on my eyeball and CI