Fix^2 prefix extractor testing in crash test #9463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Even after facebook#9461 could see ``` Error: please specify prefix_size for test_batches_snapshots test! ``` Test Plan: run `make blackbox_crashtest` for a long time`
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
akankshamahajan15
approved these changes
Jan 28, 2022
pdillinger
added a commit
to pdillinger/rocksdb
that referenced
this pull request
Jan 31, 2022
Summary: Even after facebook#9461 could see ``` Error: please specify prefix_size for test_batches_snapshots test! ``` Pull Request resolved: facebook#9463 Test Plan: run `make blackbox_crashtest` for a long time. (Unfortunately, it's taking a long time to reproduce these failures) Reviewed By: akankshamahajan15 Differential Revision: D33838152 Pulled By: pdillinger fbshipit-source-id: b9a73c5bbb68df53f14c22b9b52f61d1f7ef38af
pdillinger
added a commit
to pdillinger/rocksdb
that referenced
this pull request
Jan 31, 2022
Summary: Even after facebook#9461 could see ``` Error: please specify prefix_size for test_batches_snapshots test! ``` Pull Request resolved: facebook#9463 Test Plan: run `make blackbox_crashtest` for a long time. (Unfortunately, it's taking a long time to reproduce these failures) Reviewed By: akankshamahajan15 Differential Revision: D33838152 Pulled By: pdillinger fbshipit-source-id: b9a73c5bbb68df53f14c22b9b52f61d1f7ef38af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Even after #9461 could see
Test Plan: run
make blackbox_crashtestfor a long time. (Unfortunately,it's taking a long time to reproduce these failures)