regenerate config jsons, reduce noise #9644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D34543778 |
jay-zhuang
approved these changes
Mar 1, 2022
Comment on lines
+219
to
+222
| for metric in overloaded_metric_list: | ||
| if not isinstance(metric, dict): | ||
| clean_benchmarks[binary][benchmark].append(metric) | ||
| TARGETS.add_fancy_bench_config(config_dict['name'], clean_benchmarks, False, config_dict['expected_runtime_one_iter'], config_dict['sl_iterations'], config_dict['regression_threshold']) |
There was a problem hiding this comment.
maybe the default setting could be added here?
There was a problem hiding this comment.
it is added upstream of the json
jay-zhuang
added a commit
to jay-zhuang/rocksdb
that referenced
this pull request
Mar 1, 2022
Better use the released clang-format version instead of the one from dev branch. Otherwise the format report could be inconsistent with local development env and CI. e.g.: facebook#9644 Test Plan: CI
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
Summary: We should use the released clang-format version instead of the one from dev branch. Otherwise the format report could be inconsistent with local development env and CI. e.g.: #9644 Pull Request resolved: #9646 Test Plan: CI Reviewed By: riversand963 Differential Revision: D34554065 Pulled By: jay-zhuang fbshipit-source-id: b841bc400becb4272be18c803eb03a7a1172da6f
|
This pull request was exported from Phabricator. Differential Revision: D34543778 |
likewhatevs
force-pushed
the
export-D34543778
branch
from
60cee11
to
c9d727f
Compare
Summary: Pull Request resolved: facebook#9643 Differential Revision: D34543573 fbshipit-source-id: 4fbe6b31c8e2f1afb68fec9573e9c7bd1a853011
Summary: Pull Request resolved: facebook#9644 Reviewed By: jay-zhuang Differential Revision: D34543778 fbshipit-source-id: a637bcedb79c63bc7c8c342f6496ec07065c2ed5
likewhatevs
force-pushed
the
export-D34543778
branch
from
c9d727f
to
fcdcca9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34543778 |
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
Mar 8, 2023
…k#9646) Summary: We should use the released clang-format version instead of the one from dev branch. Otherwise the format report could be inconsistent with local development env and CI. e.g.: facebook#9644 Pull Request resolved: facebook#9646 Test Plan: CI Reviewed By: riversand963 Differential Revision: D34554065 Pulled By: jay-zhuang fbshipit-source-id: b841bc400becb4272be18c803eb03a7a1172da6f
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
Mar 8, 2023
…k#9646) Summary: We should use the released clang-format version instead of the one from dev branch. Otherwise the format report could be inconsistent with local development env and CI. e.g.: facebook#9644 Pull Request resolved: facebook#9646 Test Plan: CI Reviewed By: riversand963 Differential Revision: D34554065 Pulled By: jay-zhuang fbshipit-source-id: b841bc400becb4272be18c803eb03a7a1172da6f Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D34543778