update buckifier for new json format and updated macros #9643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D34543573 |
jay-zhuang
approved these changes
Mar 1, 2022
| @@ -41,6 +41,6 @@ | |||
| """ | |||
|
|
|||
| fancy_bench_template = """ | |||
| fancy_bench_wrapper(suite_name="{name}", binary_to_bench_to_metric_list_map={bench_config}, slow={slow}, expected_runtime={expected_runtime}) | |||
| fancy_bench_wrapper(suite_name="{name}", binary_to_bench_to_metric_list_map={bench_config}, slow={slow}, expected_runtime={expected_runtime}, sl_iterations={sl_iterations}, regression_threshold={regression_threshold}) | |||
There was a problem hiding this comment.
Should we set a default value here?
Is there any other parameter we could use?
Is the setting per test or test_suit?
There was a problem hiding this comment.
The json's contain default parameters, these are per test suite.
There was a problem hiding this comment.
would be great to have per test config. (maybe with later diff).
Summary: Pull Request resolved: facebook#9643 Reviewed By: jay-zhuang Differential Revision: D34543573 fbshipit-source-id: c968f4f8920712af5cbf41cadd409bc72c859246
|
This pull request was exported from Phabricator. Differential Revision: D34543573 |
likewhatevs
force-pushed
the
export-D34543573
branch
from
2a1bd18
to
aa53012
Compare
likewhatevs
pushed a commit
to likewhatevs/rocksdb
that referenced
this pull request
Mar 1, 2022
Summary: Pull Request resolved: facebook#9643 Differential Revision: D34543573 fbshipit-source-id: 4fbe6b31c8e2f1afb68fec9573e9c7bd1a853011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D34543573