Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in PosixClock #9695

Closed
wants to merge 3 commits into from
Closed

Fix a bug in PosixClock #9695

wants to merge 3 commits into from

Conversation

KNOEEE
Copy link
Contributor

@KNOEEE KNOEEE commented Mar 15, 2022

Multiplier here should be 1e6 to get microseconds.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@jay-zhuang jay-zhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

env/env_posix.cc Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@KNOEEE has updated the pull request. You must reimport the pull request before landing.

@KNOEEE KNOEEE requested a review from pdillinger March 17, 2022 16:02
@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@KNOEEE has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@KNOEEE KNOEEE deleted the fix_clock branch March 22, 2022 02:45
ajkr pushed a commit that referenced this pull request Mar 29, 2022
Summary:
Multiplier here should be 1e6 to get microseconds.

Pull Request resolved: #9695

Reviewed By: ajkr

Differential Revision: D34897086

Pulled By: jay-zhuang

fbshipit-source-id: 9c1d0811ea740ba0a007edc2da199edbd000b88b
ajkr pushed a commit that referenced this pull request Mar 29, 2022
Summary:
Multiplier here should be 1e6 to get microseconds.

Pull Request resolved: #9695

Reviewed By: ajkr

Differential Revision: D34897086

Pulled By: jay-zhuang

fbshipit-source-id: 9c1d0811ea740ba0a007edc2da199edbd000b88b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants